Normative: set [[SourceText]] in NamedEvaluation of ClassExpression #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
normative change
ljharb
approved these changes
Jun 4, 2019
|
That's a larger PR, so it'd be good to land this first :-) |
|
Okay, wasn't sure about protocol. |
zenparsing
approved these changes
Jul 17, 2019
ljharb
changed the title
ljharb
force-pushed
the
namedevaluation-classexpression
branch
from
98ea9f9 to
446956a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1560, we discovered that deferring NamedEvaluation to the evaluation algorithm for ClassExpressions would cause an undesirable change in behaviour. So this PR is the alternative: keep NamedEvaluation of ClassExpression special and set its
[[SourceText]]slot.This should be the last missing
[[SourceText]]slot 🤞.