Use blocking connection pool #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53.
I decided not to add
timeout
argument at the moment, because any unknown argument passed to constructor is passed to theBlockedConnectionPool
(includingtimeout
if user wishes to customize it).BlockingConnectionPool
default is 20 seconds. If you think it's too high, we can still customize that value without changing constructors themselves, like this:TODO
ConnectionPool
withBlockingConnectionPool
connection_kwargs
(and max connections) to result backends