implement redis cluster broker #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3rius
reviewed
Nov 10, 2023
|
To fix all lint problems, simply use |
pinguingman
force-pushed
the
add-cluster-broker
branch
from
e325ce2 to
bc45417
Compare
|
I fixed all linter problems and review issue. Waiting for the second review |
s3rius
approved these changes
Nov 13, 2023
|
Can you also remove result backend from the constructor? |
|
Removed result backend |
|
All target python tests passed. Sorry for codecov error. I will fix it in a subsequent PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes updates to support the redis cluster option for the List Queue broker. The changes involve the addition of the BaseRedisClusterBroker and ListQueueClusterBroker.