Continuum transitions #3318
Merged
Continuum transitions #3318
+2,557
−533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lities between levels and k
…ardis-sn#3183) * Refactor progress bar handling and improve convergence plot updates * Refactor progress bar initialization and layout handling for improved clarity and performance * Add monkeysession import to conftest.py for test utilities * Remove is_notebook function to clean up unused code * Refactor progress bar layout and improve environment detection; add warnings for plot rendering issues in convergence plots * Refactor Monte Carlo transport progress bar handling and improve code readability - Updated progress bar functions to enhance clarity and functionality. - Introduced `update_packets_pbar` for updating packet progress without iteration logic. - Added `reset_packet_pbar` to reset the packet progress bar for new iterations. - Refactored existing progress bar updates in the Monte Carlo main loop. - Improved code formatting and consistency across various classes and methods. - Enhanced import statements for better organization and readability. * Refactor SimpleTARDISWorkflow to improve progress bar handling and code organization * reset quickstart * duplicate init notebook mode * remove extra try except block * remove unused function * Refactor montecarlo_main_loop and progress bar utilities for improved readability and type hinting --------- Co-authored-by: Atharva Arya <[email protected]>
jvshields
requested review from
andrewfullard,
connor-mcclellan and
wkerzendorf
Open
tardis/opacities/macro_atom/tests/test_continuum_transitions.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I think the benchmarks are failing because the imports in the benchmark file got changed, so they can't find the function to import in the old commit checkout. |
andrewfullard
approved these changes
Dec 5, 2025
Contributor
There was a problem hiding this comment.
Just confirming that this is included intentionally - is this needed for pytest, or are these macroatom tests imported as a module somewhere I'm not seeing?
Contributor
Author
There was a problem hiding this comment.
Reasonable question. I didn't think too much about it since most of our test directories include one. I don't think we usually import tests, but I also don't remember off the top of my head if it's important for any pytest or fixture functionality.
connor-mcclellan
approved these changes
Dec 5, 2025
Contributor
connor-mcclellan
left a comment
connor-mcclellan
left a comment
There was a problem hiding this comment.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run the simulation crashes with
PlasmaException: Negative values in CorrPhotoIonRateCoeff. Try raising the number of montecarlo packets.This bug MAY be due to an incorrect calculation of CorrPhotoIonRateCoeff. It was investigated briefly by Connor and it seems like CorrPhotoIonRateCoeff or the values used to calculate it differ from analytic values calculated in some of the solvers used for Andrew's ionization and excitation calculations, and may resolve with that.