Skip to content

Conversation

@atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Aug 27, 2025

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

#3151 (comment)

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and I noticed that your email is not associated with an ORCID ID in our database.

Please add your email and ORCID ID to the .orcid.csv file in your current branch and push the changes to this pull request.

If you don't have an ORCID ID yet, you can create one for free at orcid.org. ORCID IDs help ensure you get proper credit for your scientific contributions.

The format should be:

email,orcid
[email protected],0000-0000-0000-0000

@tardis-bot
Copy link
Contributor

tardis-bot commented Aug 27, 2025

*beep* *bop*
Hi human,
I ran ruff on the latest commit (9325940).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

Details
6526	       	[ ] syntax-error
47	W293   	[ ] blank-line-with-whitespace
38	E701   	[ ] multiple-statements-on-one-line-colon
20	E902   	[ ] io-error
18	F821   	[ ] undefined-name
18	I001   	[*] unsorted-imports
16	F401   	[ ] unused-import
15	D202   	[*] blank-line-after-function
14	G004   	[ ] logging-f-string
12	W291   	[ ] trailing-whitespace
11	RET505 	[*] superfluous-else-return
 8	E702   	[ ] multiple-statements-on-one-line-semicolon
 8	F405   	[ ] undefined-local-with-import-star-usage
 8	UP008  	[ ] super-call-with-parameters
 7	E402   	[ ] module-import-not-at-top-of-file
 6	W292   	[ ] missing-newline-at-end-of-file
 5	E722   	[ ] bare-except
 4	B019   	[ ] cached-instance-method
 4	F811   	[ ] redefined-while-unused
 3	B011   	[ ] assert-false
 3	C408   	[ ] unnecessary-collection-call
 3	D209   	[*] new-line-after-last-paragraph
 3	NPY201 	[ ] numpy2-deprecation
 3	PT015  	[ ] pytest-assert-always-false
 3	RUF022 	[*] unsorted-dunder-all
 2	B027   	[ ] empty-method-without-abstract-decorator
 2	F403   	[ ] undefined-local-with-import-star
 2	FA102  	[ ] future-required-type-annotation
 2	RET506 	[*] superfluous-else-raise
 1	ANN002 	[ ] missing-type-args
 1	ANN204 	[ ] missing-return-type-special-method
 1	B018   	[ ] useless-expression
 1	COM818 	[ ] trailing-comma-on-bare-tuple
 1	D406   	[*] missing-new-line-after-section-name
 1	D412   	[*] blank-lines-between-header-and-content
 1	FA100  	[ ] future-rewritable-type-annotation
 1	FURB187	[ ] list-reverse-copy
 1	G001   	[ ] logging-string-format
 1	ICN001 	[ ] unconventional-import-alias
 1	INP001 	[ ] implicit-namespace-package
 1	ISC003 	[*] explicit-string-concatenation
 1	PGH004 	[ ] blanket-noqa
 1	PIE790 	[*] unnecessary-placeholder
 1	PT021  	[ ] pytest-fixture-finalizer-callback
 1	RET508 	[*] superfluous-else-break
 1	RUF003 	[ ] ambiguous-unicode-character-comment
 1	RUF021 	[*] parenthesize-chained-operators
 1	TRY300 	[ ] try-consider-else
 1	UP004  	[*] useless-object-inheritance
 1	UP024  	[*] os-error-alias
Found 6832 errors.
[*] 91 fixable with the `--fix` option (21 hidden fixes can be enabled with the `--unsafe-fixes` option).

Complete output(might be large):

Details
benchmarks/benchmark_base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
benchmarks/benchmark_base.py:74:9: RET506 [*] Unnecessary `else` after `raise` statement
benchmarks/spectrum_formal_integral.py:5:1: I001 [*] Import block is un-sorted or un-formatted
benchmarks/spectrum_formal_integral.py:28:5: B019 Use of `functools.lru_cache` or `functools.cache` on methods can lead to memory leaks
benchmarks/transport_montecarlo_main_loop.py:20:5: B019 Use of `functools.lru_cache` or `functools.cache` on methods can lead to memory leaks
benchmarks/transport_montecarlo_packet_trackers.py:6:40: F401 [*] `asv_runner.benchmarks.mark.parameterize` imported but unused
benchmarks/transport_montecarlo_packet_trackers.py:19:5: B019 Use of `functools.lru_cache` or `functools.cache` on methods can lead to memory leaks
benchmarks/transport_montecarlo_vpacket.py:54:5: B019 Use of `functools.lru_cache` or `functools.cache` on methods can lead to memory leaks
tardis/analysis.py:96:9: E722 Do not use bare `except`
tardis/analysis.py:110:9: E722 Do not use bare `except`
tardis/analysis.py:121:9: E722 Do not use bare `except`
tardis/analysis.py:136:9: E722 Do not use bare `except`
tardis/analysis.py:374:9: RET505 [*] Unnecessary `else` after `return` statement
tardis/analysis.py:396:9: RET505 [*] Unnecessary `else` after `return` statement
tardis/analysis.py:421:9: RET505 [*] Unnecessary `else` after `return` statement
tardis/configuration/__init__.py:1:1: E902 No such file or directory (os error 2)
tardis/configuration/sorting_globals.py:1:1: E902 No such file or directory (os error 2)
tardis/conftest.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/conftest.py:12:1: F403 `from tardis.tests.fixtures.atom_data import *` used; unable to detect undefined names
tardis/conftest.py:15:36: F401 [*] `tardis.tests.test_util.monkeysession` imported but unused
tardis/conftest.py:18:12: F401 `tardisbase` imported but unused; consider using `importlib.util.find_spec` to test for availability
tardis/conftest.py:39:49: PGH004 Use specific rule codes when using `noqa`
tardis/conftest.py:41:9: F821 Undefined name `pytest_report_header`
tardis/energy_input/gamma_ray_packet_source.py:85:53: ANN002 Missing type annotation for `*args`
tardis/energy_input/gamma_ray_packet_source.py:208:41: FA102 Missing `from __future__ import annotations`, but uses PEP 604 union
tardis/energy_input/gamma_ray_packet_source.py:358:35: FA102 Missing `from __future__ import annotations`, but uses PEP 604 union
tardis/energy_input/main_gamma_ray_loop.py:30:23: FA100 Add `from __future__ import annotations` to simplify `typing.Optional`
tardis/energy_input/samplers.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/energy_input/samplers.py:155:49: NPY201 `np.trapz` will be removed in NumPy 2.0. Use `numpy.trapezoid` on NumPy 2.0, or ignore this warning on earlier versions.
tardis/energy_input/samplers.py:178:1: W293 [*] Blank line contains whitespace
tardis/energy_input/samplers.py:190:53: W291 [*] Trailing whitespace
tardis/energy_input/samplers.py:191:35: W291 [*] Trailing whitespace
tardis/energy_input/samplers.py:192:28: W292 [*] No newline at end of file
tardis/energy_input/tests/test_energy_source.py:35:5: PT015 Assertion always fails, replace with `pytest.fail()`
tardis/energy_input/tests/test_energy_source.py:35:12: B011 Do not `assert False` (`python -O` removes these calls), raise `AssertionError()`
tardis/energy_input/tests/test_energy_source.py:41:5: PT015 Assertion always fails, replace with `pytest.fail()`
tardis/energy_input/tests/test_energy_source.py:41:12: B011 Do not `assert False` (`python -O` removes these calls), raise `AssertionError()`
tardis/energy_input/tests/test_energy_source.py:47:5: PT015 Assertion always fails, replace with `pytest.fail()`
tardis/energy_input/tests/test_energy_source.py:47:12: B011 Do not `assert False` (`python -O` removes these calls), raise `AssertionError()`
tardis/energy_input/tests/test_gamma_ray_packet_source_minimal.py:5:17: F401 [*] `numpy` imported but unused
tardis/gui/widgets.py:7:5: I001 [*] Import block is un-sorted or un-formatted
tardis/gui/widgets.py:9:5: I001 [*] Import block is un-sorted or un-formatted
tardis/gui/widgets.py:17:1: I001 [*] Import block is un-sorted or un-formatted
tardis/gui/widgets.py:17:8: ICN001 `matplotlib` should be imported as `mpl`
tardis/gui/widgets.py:18:1: F403 `from matplotlib.figure import *` used; unable to detect undefined names
tardis/gui/widgets.py:25:32: F401 [*] `matplotlib.patches.Circle` imported but unused
tardis/gui/widgets.py:30:30: F401 [*] `tardis.util` imported but unused
tardis/gui/widgets.py:37:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/gui/widgets.py:44:23: F405 `Figure` may be undefined, or defined from star imports
tardis/gui/widgets.py:55:14: UP008 Use `super()` instead of `super(__class__, self)`
tardis/gui/widgets.py:56:14: UP008 Use `super()` instead of `super(__class__, self)`
tardis/gui/widgets.py:59:14: UP008 Use `super()` instead of `super(__class__, self)`
tardis/gui/widgets.py:165:27: C408 Unnecessary `dict()` call (rewrite as a literal)
tardis/gui/widgets.py:168:26: C408 Unnecessary `dict()` call (rewrite as a literal)
tardis/gui/widgets.py:169:23: C408 Unnecessary `dict()` call (rewrite as a literal)
tardis/gui/widgets.py:187:9: RET505 [*] Unnecessary `elif` after `return` statement
tardis/gui/widgets.py:199:14: UP008 Use `super()` instead of `super(__class__, self)`
tardis/gui/widgets.py:227:14: UP008 Use `super()` instead of `super(__class__, self)`
tardis/gui/widgets.py:230:22: F405 `yaml` may be undefined, or defined from star imports
tardis/gui/widgets.py:230:61: F405 `yaml` may be undefined, or defined from star imports
tardis/gui/widgets.py:354:24: F405 `TreeModel` may be undefined, or defined from star imports
tardis/gui/widgets.py:359:38: F405 `TreeDelegate` may be undefined, or defined from star imports
tardis/gui/widgets.py:430:35: UP024 [*] Replace aliased errors with `OSError`
tardis/gui/widgets.py:445:9: PIE790 [*] Unnecessary `pass` statement
tardis/gui/widgets.py:529:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/gui/widgets.py:647:41: F405 `np` may be undefined, or defined from star imports
tardis/gui/widgets.py:658:9: D209 [*] Multi-line docstring closing quotes should be on a separate line
tardis/gui/widgets.py:661:41: F405 `np` may be undefined, or defined from star imports
tardis/gui/widgets.py:689:41: F405 `np` may be undefined, or defined from star imports
tardis/gui/widgets.py:816:14: UP008 Use `super()` instead of `super(__class__, self)`
tardis/gui/widgets.py:852:9: D209 [*] Multi-line docstring closing quotes should be on a separate line
tardis/gui/widgets.py:928:9: D209 [*] Multi-line docstring closing quotes should be on a separate line
tardis/gui/widgets.py:930:14: UP008 Use `super()` instead of `super(__class__, self)`
tardis/gui/widgets.py:1125:14: UP008 Use `super()` instead of `super(__class__, self)`
tardis/gui/widgets.py:1232:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/io/atom_data/base.py:197:34: G004 Logging statement uses f-string
tardis/io/atom_data/base.py:259:17: G004 Logging statement uses f-string
tardis/io/atom_data/base.py:263:21: G001 Logging statement uses `str.format`
tardis/io/atom_data/base.py:707:17: G004 Logging statement uses f-string
tardis/model/matter/composition.py:173:9: RET505 [*] Unnecessary `else` after `return` statement
tardis/model/matter/decay.py:101:21: G004 Logging statement uses f-string
tardis/opacities/macro_atom/transition_probabilities.py:15:11: RUF022 [*] `__all__` is not sorted
tardis/plasma/properties/atomic.py:27:11: RUF022 [*] `__all__` is not sorted
tardis/plasma/properties/atomic.py:554:9: RET505 [*] Unnecessary `else` after `return` statement
tardis/plasma/properties/atomic.py:585:9: RET505 [*] Unnecessary `else` after `return` statement
tardis/plasma/properties/atomic.py:598:17: G004 Logging statement uses f-string
tardis/plasma/properties/atomic.py:639:9: RET505 [*] Unnecessary `else` after `return` statement
tardis/plasma/properties/continuum_processes/rates.py:22:11: RUF022 [*] `__all__` is not sorted
tardis/plasma/properties/continuum_processes/rates.py:156:13: FURB187 Use of assignment of `reversed` on list `idx_arrays`
tardis/radiation_field/base.py:1:1: INP001 File `tardis/radiation_field/base.py` is part of an implicit namespace package. Add an `__init__.py`.
tardis/simulation/base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/simulation/base.py:245:17: G004 Logging statement uses f-string
tardis/simulation/base.py:418:13: G004 Logging statement uses f-string
tardis/simulation/base.py:519:13: G004 Logging statement uses f-string
tardis/simulation/base.py:605:13: G004 Logging statement uses f-string
tardis/simulation/base.py:610:13: G004 Logging statement uses f-string
tardis/simulation/base.py:661:13: TRY300 Consider moving this statement to an `else` block
tardis/simulation/base.py:663:26: G004 Logging statement uses f-string
tardis/spectrum/base.py:98:43: W291 [*] Trailing whitespace
tardis/spectrum/base.py:99:36: W291 [*] Trailing whitespace
tardis/spectrum/base.py:100:33: W291 [*] Trailing whitespace
tardis/spectrum/base.py:101:40: W291 [*] Trailing whitespace
tardis/spectrum/formal_integral/formal_integral_solver.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/formal_integral_solver.py:11:50: F401 [*] `tardis.spectrum.formal_integral.base.check` imported but unused
tardis/spectrum/formal_integral/formal_integral_solver.py:47:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/formal_integral_solver.py:76:17: G004 Logging statement uses f-string
tardis/spectrum/formal_integral/formal_integral_solver.py:98:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/formal_integral_solver.py:144:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/formal_integral_solver.py:260:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/formal_integral_solver.py:354:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/source_function.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/source_function.py:16:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/source_function.py:28:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/source_function.py:151:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/source_function.py:232:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/source_function.py:280:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/source_function.py:310:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/source_function.py:322:5: D412 [*] No blank lines allowed between a section header and its content ("Attributes")
tardis/spectrum/formal_integral/source_function.py:322:5: D406 [*] Section name should end with a newline ("Attributes")
tardis/spectrum/formal_integral/tests/test_cuda_formal_integral.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/tests/test_cuda_formal_integral.py:9:5: F401 [*] `tardis.spectrum.formal_integral.base.interpolate_integrator_quantities` imported but unused
tardis/spectrum/formal_integral/tests/test_cuda_formal_integral.py:15:61: F401 [*] `tardis.spectrum.formal_integral.source_function.SourceFunctionSolver` imported but unused
tardis/spectrum/formal_integral/tests/test_cuda_formal_integral.py:345:55: W292 [*] No newline at end of file
tardis/spectrum/formal_integral/tests/test_source_function.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/__init__.py:14:1: E402 Module level import not at top of file
tardis/transport/montecarlo/__init__.py:24:1: E402 Module level import not at top of file
tardis/transport/montecarlo/__init__.py:25:5: F401 `tardis.transport.montecarlo.packet_collections.PacketCollection` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/transport/montecarlo/__init__.py:27:1: E402 Module level import not at top of file
tardis/transport/montecarlo/__init__.py:27:50: F401 `tardis.transport.montecarlo.r_packet.RPacket` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/transport/montecarlo/base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/base.py:10:56: F401 [*] `tardis.opacities.continuum.continuum_state.ContinuumState` imported but unused
tardis/transport/montecarlo/base.py:12:5: F401 [*] `tardis.opacities.opacity_state.OpacityState` imported but unused
tardis/transport/montecarlo/estimators/util.py:66:32: NPY201 `np.trapz` will be removed in NumPy 2.0. Use `numpy.trapezoid` on NumPy 2.0, or ignore this warning on earlier versions.
tardis/transport/montecarlo/numba_interface.py:114:9: ANN204 Missing return type annotation for special method `__getitem__`
tardis/transport/montecarlo/packet_source.py:45:5: B027 `BasePacketSource.create_packet_radii` is an empty method in an abstract base class, but has no abstract decorator
tardis/transport/montecarlo/packet_source.py:48:5: B027 `BasePacketSource.create_packet_velocities` is an empty method in an abstract base class, but has no abstract decorator
tardis/transport/montecarlo/packet_source.py:249:9: RET505 [*] Unnecessary `else` after `return` statement
tardis/transport/montecarlo/packet_source/__init__.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packet_source/base.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packet_source/black_body.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packet_source/black_body_relativistic.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packet_source/black_body_weighted.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packet_source/tests/__init__.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packet_source/tests/conftest.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packet_source/tests/test_base.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packets/__init__.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packets/radiative_packet.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packets/tests/__init__.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packets/tests/conftest.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/progress_bars.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/r_packet_transport.py:115:13: RET508 [*] Unnecessary `elif` after `break` statement
tardis/transport/montecarlo/tests/conftest.py:14:5: F811 Redefinition of unused `opacity_state_initialize` from line 7
tardis/transport/montecarlo/tests/test_montecarlo.py:26:1: E402 Module level import not at top of file
tardis/transport/montecarlo/tests/test_montecarlo.py:31:1: E402 Module level import not at top of file
tardis/transport/montecarlo/tests/test_montecarlo.py:47:5: PT021 Use `yield` instead of `request.addfinalizer`
tardis/transport/montecarlo/tests/test_montecarlo.py:104:5: F811 Redefinition of unused `test_get_random_mu_different_output` from line 95
tardis/transport/montecarlo/tests/test_montecarlo.py:384:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:470:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:471:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:479:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:496:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:501:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:524:9: F821 Undefined name `transport`
tardis/transport/montecarlo/tests/test_montecarlo.py:525:9: F821 Undefined name `transport`
tardis/transport/montecarlo/tests/test_montecarlo.py:526:9: F821 Undefined name `transport`
tardis/transport/montecarlo/tests/test_montecarlo.py:527:9: F821 Undefined name `transport`
tardis/transport/montecarlo/tests/test_montecarlo.py:529:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:542:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:566:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:579:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_packet.py:21:1: E402 Module level import not at top of file
tardis/transport/montecarlo/tests/test_vpacket.py:12:1: E402 Module level import not at top of file
tardis/transport/montecarlo/weighted_packet_source.py:79:13: B018 Found useless expression. Either assign it to a variable or remove it.
tardis/util/base.py:185:20: NPY201 `np.trapz` will be removed in NumPy 2.0. Use `numpy.trapezoid` on NumPy 2.0, or ignore this warning on earlier versions.
tardis/util/base.py:336:5: RET505 [*] Unnecessary `else` after `return` statement
tardis/util/base.py:510:5: E722 Do not use bare `except`
tardis/visualization/tools/convergence_plot.py:3:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/tools/convergence_plot.py:7:22: F401 [*] `matplotlib` imported but unused
tardis/visualization/tools/convergence_plot.py:15:2: RUF003 Comment contains ambiguous ` ` (NO-BREAK SPACE). Did you mean ` ` (SPACE)?
tardis/visualization/tools/convergence_plot.py:18:29: F811 [*] Redefinition of unused `display` from line 11
tardis/visualization/tools/convergence_plot.py:26:24: UP004 [*] Class `ConvergencePlots` inherits from `object`
tardis/visualization/tools/convergence_plot.py:310:13: ISC003 [*] Explicitly concatenated string should be implicitly concatenated
tardis/visualization/widgets/custom_abundance.py:737:16: RUF021 [*] Parenthesize `a and b` expressions when chaining `and` and `or` together, to make the precedence clear
tardis/visualization/widgets/custom_abundance.py:1127:9: RET505 [*] Unnecessary `else` after `return` statement
tardis/visualization/widgets/custom_abundance.py:1418:9: RET506 [*] Unnecessary `else` after `raise` statement
tardis/visualization/widgets/custom_abundance.py:1721:9: F811 Redefinition of unused `input_d_time_0_eventhandler` from line 1710
tardis/visualization/widgets/custom_abundance.py:1751:13: F821 Undefined name `display`
tardis/visualization/widgets/custom_abundance.py:1753:13: F821 Undefined name `display`
tardis/visualization/widgets/custom_abundance.py:1755:13: F821 Undefined name `display`
tardis/visualization/widgets/line_info.py:3:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/widgets/line_info.py:450:1: W293 [*] Blank line contains whitespace
tardis/visualization/widgets/line_info.py:454:1: W293 [*] Blank line contains whitespace
tardis/visualization/widgets/line_info.py:458:1: W293 [*] Blank line contains whitespace
tardis/visualization/widgets/line_info.py:462:1: W293 [*] Blank line contains whitespace
tardis/visualization/widgets/line_info.py:467:1: W293 [*] Blank line contains whitespace
tardis/visualization/widgets/line_info.py:476:1: W293 [*] Blank line contains whitespace
tardis/visualization/widgets/line_info.py:531:1: W293 [*] Blank line contains whitespace
tardis/visualization/widgets/line_info.py:715:1: W293 [*] Blank line contains whitespace
tardis/workflows/simple_tardis_workflow.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/workflows/simple_tardis_workflow.py:249:17: G004 Logging statement uses f-string
tardis/workflows/simple_tardis_workflow.py:470:17: G004 Logging statement uses f-string
Found 201 errors.
[*] 86 fixable with the `--fix` option (21 hidden fixes can be enabled with the `--unsafe-fixes` option).

@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.77%. Comparing base (f70fee8) to head (9325940).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3269      +/-   ##
==========================================
- Coverage   74.11%   67.77%   -6.35%     
==========================================
  Files         259      173      -86     
  Lines       17866    13230    -4636     
==========================================
- Hits        13241     8966    -4275     
+ Misses       4625     4264     -361     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

uses: tardis-sn/tardis-actions/setup-env@main
with:
os-label: linux-64
lock-file-url-prefix: "https://raw.githubusercontent.com/tardis-sn/tardis/master"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to use the local lock file? I don't think we should download. It should pass with the one that is in the repo not the one on master

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't exist yet, but I can add it- tardis-sn/tardis-actions#7

@github-project-automation github-project-automation bot moved this to Todo in DevOps Sep 3, 2025
@atharva-2001 atharva-2001 added CI/CD github_actions Pull requests that update GitHub Actions code labels Sep 3, 2025
@atharva-2001 atharva-2001 marked this pull request as ready for review September 3, 2025 13:50
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you update the branch

@andrewfullard andrewfullard merged commit 5c5c341 into tardis-sn:master Sep 5, 2025
20 of 24 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in DevOps Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD github_actions Pull requests that update GitHub Actions code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants