Skip to content

Conversation

@riddhigangbhoj
Copy link
Contributor

@riddhigangbhoj riddhigangbhoj commented Aug 27, 2025

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure
Remove tests from tests coverage
After:
image
Before:
image

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and I noticed that your email is not associated with an ORCID ID in our database.

Please add your email and ORCID ID to the .orcid.csv file in your current branch and push the changes to this pull request.

If you don't have an ORCID ID yet, you can create one for free at orcid.org. ORCID IDs help ensure you get proper credit for your scientific contributions.

The format should be:

email,orcid
[email protected],0000-0000-0000-0000

@tardis-bot
Copy link
Contributor

tardis-bot commented Aug 27, 2025

*beep* *bop*
Hi human,
I ran ruff on the latest commit (7b4c1aa).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

Details
29	      	[ ] syntax-error
14	F821  	[ ] undefined-name
12	E902  	[ ] io-error
12	D202  	[*] blank-line-after-function
11	F401  	[ ] unused-import
11	I001  	[*] unsorted-imports
9	G004  	[ ] logging-f-string
7	E402  	[ ] module-import-not-at-top-of-file
4	W291  	[*] trailing-whitespace
3	B019  	[ ] cached-instance-method
2	B027  	[ ] empty-method-without-abstract-decorator
2	F811  	[ ] redefined-while-unused
2	FA102 	[ ] future-required-type-annotation
1	W292  	[*] missing-newline-at-end-of-file
1	W293  	[ ] blank-line-with-whitespace
1	ANN002	[ ] missing-type-args
1	ANN204	[ ] missing-return-type-special-method
1	B018  	[ ] useless-expression
1	D406  	[*] missing-new-line-after-section-name
1	D412  	[*] blank-lines-between-header-and-content
1	FA100 	[ ] future-rewritable-type-annotation
1	INP001	[ ] implicit-namespace-package
1	PT021 	[ ] pytest-fixture-finalizer-callback
1	RET505	[*] superfluous-else-return
1	RET506	[*] superfluous-else-raise
1	RET508	[*] superfluous-else-break
1	TRY300	[ ] try-consider-else
Found 132 errors.
[*] 42 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

Complete output(might be large):

Details
benchmarks/benchmark_base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
benchmarks/benchmark_base.py:74:9: RET506 [*] Unnecessary `else` after `raise` statement
benchmarks/spectrum_formal_integral.py:5:1: I001 [*] Import block is un-sorted or un-formatted
benchmarks/spectrum_formal_integral.py:28:5: B019 Use of `functools.lru_cache` or `functools.cache` on methods can lead to memory leaks
benchmarks/transport_montecarlo_packet_trackers.py:6:40: F401 [*] `asv_runner.benchmarks.mark.parameterize` imported but unused
benchmarks/transport_montecarlo_packet_trackers.py:19:5: B019 Use of `functools.lru_cache` or `functools.cache` on methods can lead to memory leaks
benchmarks/transport_montecarlo_vpacket.py:54:5: B019 Use of `functools.lru_cache` or `functools.cache` on methods can lead to memory leaks
tardis/energy_input/gamma_ray_packet_source.py:85:53: ANN002 Missing type annotation for `*args`
tardis/energy_input/gamma_ray_packet_source.py:208:41: FA102 Missing `from __future__ import annotations`, but uses PEP 604 union
tardis/energy_input/gamma_ray_packet_source.py:358:35: FA102 Missing `from __future__ import annotations`, but uses PEP 604 union
tardis/energy_input/main_gamma_ray_loop.py:30:23: FA100 Add `from __future__ import annotations` to simplify `typing.Optional`
tardis/energy_input/tests/test_gamma_ray_packet_source_minimal.py:5:17: F401 [*] `numpy` imported but unused
tardis/radiation_field/base.py:1:1: INP001 File `tardis/radiation_field/base.py` is part of an implicit namespace package. Add an `__init__.py`.
tardis/simulation/base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/simulation/base.py:245:17: G004 Logging statement uses f-string
tardis/simulation/base.py:418:13: G004 Logging statement uses f-string
tardis/simulation/base.py:519:13: G004 Logging statement uses f-string
tardis/simulation/base.py:605:13: G004 Logging statement uses f-string
tardis/simulation/base.py:610:13: G004 Logging statement uses f-string
tardis/simulation/base.py:661:13: TRY300 Consider moving this statement to an `else` block
tardis/simulation/base.py:663:26: G004 Logging statement uses f-string
tardis/spectrum/base.py:98:43: W291 [*] Trailing whitespace
tardis/spectrum/base.py:99:36: W291 [*] Trailing whitespace
tardis/spectrum/base.py:100:33: W291 [*] Trailing whitespace
tardis/spectrum/base.py:101:40: W291 [*] Trailing whitespace
tardis/spectrum/formal_integral/formal_integral_solver.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/formal_integral_solver.py:11:50: F401 [*] `tardis.spectrum.formal_integral.base.check` imported but unused
tardis/spectrum/formal_integral/formal_integral_solver.py:47:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/formal_integral_solver.py:76:17: G004 Logging statement uses f-string
tardis/spectrum/formal_integral/formal_integral_solver.py:98:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/formal_integral_solver.py:144:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/formal_integral_solver.py:260:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/formal_integral_solver.py:354:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/source_function.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/source_function.py:16:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/source_function.py:28:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/source_function.py:151:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/source_function.py:232:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/source_function.py:280:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/source_function.py:310:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/source_function.py:322:5: D412 [*] No blank lines allowed between a section header and its content ("Attributes")
tardis/spectrum/formal_integral/source_function.py:322:5: D406 [*] Section name should end with a newline ("Attributes")
tardis/spectrum/formal_integral/tests/test_cuda_formal_integral.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/tests/test_cuda_formal_integral.py:9:5: F401 [*] `tardis.spectrum.formal_integral.base.interpolate_integrator_quantities` imported but unused
tardis/spectrum/formal_integral/tests/test_cuda_formal_integral.py:15:61: F401 [*] `tardis.spectrum.formal_integral.source_function.SourceFunctionSolver` imported but unused
tardis/spectrum/formal_integral/tests/test_cuda_formal_integral.py:345:55: W292 [*] No newline at end of file
tardis/spectrum/formal_integral/tests/test_source_function.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/__init__.py:14:1: E402 Module level import not at top of file
tardis/transport/montecarlo/__init__.py:24:1: E402 Module level import not at top of file
tardis/transport/montecarlo/__init__.py:25:5: F401 `tardis.transport.montecarlo.packet_collections.PacketCollection` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/transport/montecarlo/__init__.py:27:1: E402 Module level import not at top of file
tardis/transport/montecarlo/__init__.py:27:50: F401 `tardis.transport.montecarlo.r_packet.RPacket` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/transport/montecarlo/base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/base.py:10:56: F401 [*] `tardis.opacities.continuum.continuum_state.ContinuumState` imported but unused
tardis/transport/montecarlo/base.py:12:5: F401 [*] `tardis.opacities.opacity_state.OpacityState` imported but unused
tardis/transport/montecarlo/numba_interface.py:114:9: ANN204 Missing return type annotation for special method `__getitem__`
tardis/transport/montecarlo/packet_source.py:45:5: B027 `BasePacketSource.create_packet_radii` is an empty method in an abstract base class, but has no abstract decorator
tardis/transport/montecarlo/packet_source.py:48:5: B027 `BasePacketSource.create_packet_velocities` is an empty method in an abstract base class, but has no abstract decorator
tardis/transport/montecarlo/packet_source.py:249:9: RET505 [*] Unnecessary `else` after `return` statement
tardis/transport/montecarlo/packet_source/__init__.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packet_source/base.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packet_source/black_body.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packet_source/black_body_relativistic.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packet_source/black_body_weighted.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packet_source/tests/__init__.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packet_source/tests/conftest.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packet_source/tests/test_base.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packets/__init__.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packets/radiative_packet.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packets/tests/__init__.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/packets/tests/conftest.py:1:1: E902 No such file or directory (os error 2)
tardis/transport/montecarlo/r_packet_transport.py:115:13: RET508 [*] Unnecessary `elif` after `break` statement
tardis/transport/montecarlo/tests/conftest.py:14:5: F811 Redefinition of unused `opacity_state_initialize` from line 7
tardis/transport/montecarlo/tests/test_montecarlo.py:26:1: E402 Module level import not at top of file
tardis/transport/montecarlo/tests/test_montecarlo.py:31:1: E402 Module level import not at top of file
tardis/transport/montecarlo/tests/test_montecarlo.py:47:5: PT021 Use `yield` instead of `request.addfinalizer`
tardis/transport/montecarlo/tests/test_montecarlo.py:104:5: F811 Redefinition of unused `test_get_random_mu_different_output` from line 95
tardis/transport/montecarlo/tests/test_montecarlo.py:384:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:470:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:471:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:479:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:496:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:501:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:524:9: F821 Undefined name `transport`
tardis/transport/montecarlo/tests/test_montecarlo.py:525:9: F821 Undefined name `transport`
tardis/transport/montecarlo/tests/test_montecarlo.py:526:9: F821 Undefined name `transport`
tardis/transport/montecarlo/tests/test_montecarlo.py:527:9: F821 Undefined name `transport`
tardis/transport/montecarlo/tests/test_montecarlo.py:529:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:542:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:566:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_montecarlo.py:579:5: F821 Undefined name `mc`
tardis/transport/montecarlo/tests/test_packet.py:21:1: E402 Module level import not at top of file
tardis/transport/montecarlo/tests/test_vpacket.py:12:1: E402 Module level import not at top of file
tardis/transport/montecarlo/weighted_packet_source.py:79:13: B018 Found useless expression. Either assign it to a variable or remove it.
tardis/workflows/simple_tardis_workflow.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/workflows/simple_tardis_workflow.py:249:17: G004 Logging statement uses f-string
tardis/workflows/simple_tardis_workflow.py:470:17: G004 Logging statement uses f-string
Found 97 errors.
[*] 37 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.71%. Comparing base (f70fee8) to head (7b4c1aa).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3267      +/-   ##
==========================================
- Coverage   74.11%   67.71%   -6.40%     
==========================================
  Files         259      171      -88     
  Lines       17866    13220    -4646     
==========================================
- Hits        13241     8952    -4289     
+ Misses       4625     4268     -357     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@riddhigangbhoj riddhigangbhoj marked this pull request as ready for review August 28, 2025 07:34
@atharva-2001 atharva-2001 added testing 🚦 github_actions Pull requests that update GitHub Actions code labels Aug 28, 2025
@github-project-automation github-project-automation bot moved this to Todo in DevOps Aug 28, 2025
@andrewfullard andrewfullard merged commit 4a7f376 into tardis-sn:master Aug 28, 2025
38 of 46 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in DevOps Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code testing 🚦

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants