Skip to content

Conversation

@atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Dec 9, 2024

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

Fixes the benchmarks workflow
Please also see this: airspeed-velocity/asv#1438
Working example: https://github.com/tardis-sn/tardis/actions/runs/12233850146/job/34121793528?pr=2902

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

tardis-bot commented Dec 9, 2024

*beep* *bop*
Hi human,
I ran ruff on the latest commit (8f66374).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

Details
7	W291	[*] Trailing whitespace
2	W293	[*] Blank line contains whitespace
1	E999	[ ] SyntaxError: Expected an expression

Complete output(might be large):

Details
.github/workflows/benchmarks.yml:3:4: E999 SyntaxError: Expected an expression
.github/workflows/benchmarks.yml:20:5: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:87:49: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:117:81: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:118:54: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:205:1: W293 [*] Blank line contains whitespace
.github/workflows/benchmarks.yml:224:22: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:225:170: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:227:84: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:244:1: W293 [*] Blank line contains whitespace
Found 10 errors.
[*] 9 fixable with the `--fix` option.

@atharva-2001 atharva-2001 marked this pull request as ready for review December 9, 2024 14:44
@andrewfullard andrewfullard self-requested a review December 9, 2024 15:03
@wkerzendorf wkerzendorf merged commit 068d33d into tardis-sn:master Dec 9, 2024
9 of 12 checks passed
@codecov
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.03%. Comparing base (a6160b7) to head (8f66374).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2902      +/-   ##
==========================================
- Coverage   70.39%   70.03%   -0.36%     
==========================================
  Files         221      221              
  Lines       16147    16147              
==========================================
- Hits        11366    11309      -57     
- Misses       4781     4838      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants