Add new metrics #342
Add new metrics #342
Conversation
- tnt_replication_upstream_<id>_lag - tnt_replication_downstream_<id>_lag - tnt_vinyl_regulator_blocked_writers - tnt_net_requests_in_progress_total - tnt_net_requests_in_progress_current - tnt_net_requests_in_stream_total - tnt_net_requests_in_stream_current
| and utils.is_version_greater(_TARANTOOL, '2.0.0') then | ||
| t.assert_equals(metrics_cnt, 20) | ||
| else | ||
| t.assert_equals(metrics_cnt, 21) |
There was a problem hiding this comment.
Well, do we really should get there if Tarantool is 1.10.x? Condition says that we will.
There was a problem hiding this comment.
Yes, seems that was backported to the latest 1.10 version
There was a problem hiding this comment.
Oh, that's interesting. But I still think we should add strict version comparison here for 1.10
yngvar-antonsson
force-pushed
the
new-metrics
branch
from
738f424 to
dfd32c4
Compare
CHANGELOG.md
Outdated
| - `tnt_net_requests_in_progress_current` | ||
| - `tnt_net_requests_in_stream_total` | ||
| - `tnt_net_requests_in_stream_current` | ||
| - `replication_lsn` |
| :header-rows: 0 | ||
|
|
||
| * - ``tnt_net_requests_in_progress_total`` | ||
| - Total count of requests processed by tx thread |
There was a problem hiding this comment.
requests_in_progress
count of requests processed
It seems like either a mistake or a bad naming
|
|
||
| * - ``tnt_net_requests_in_stream_total`` | ||
| - Total count of requests, which was placed in queues of streams | ||
| for all time |
There was a problem hiding this comment.
| for all time | |
| for the whole time |
There was a problem hiding this comment.
Or for the instance lifetime. We should have many metrics like this, choose something consistent
| - Replication lag value in seconds, where | ||
| ``id`` is the instance's number in the replica set. | ||
| * - ``tnt_replication_lsn`` | ||
| - LSN of the tarantool instance. |
There was a problem hiding this comment.
| - LSN of the tarantool instance. | |
| - LSN of a tarantool instance. |
|
Damn, I forgot to submit my last review. If anything still seems relevant, please fix it in separate PR |
I didn't forget about
Close #337