Skip to content

Fix http routes removal #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2021
Merged

Fix http routes removal #247

merged 1 commit into from
Jun 8, 2021

Conversation

rosik
Copy link
Contributor

@rosik rosik commented Jun 7, 2021

The metrics role handles http router incorrectly - it leaves gaps in the routes table. This patch fixes it.

I didn't forget about

  • Tests
  • Changelog
  • Documentation (README and rest) - unnecessary
  • Rockspec and rpm spec - unnecessary

Close #246

@rosik rosik requested a review from yngvar-antonsson June 7, 2021 17:28
@rosik
Fix http routes removal
816304c 
The cartridge role handles http router incorrectly - it leaves gaps in
the routes table. This patch fixes it.
@rosik rosik force-pushed the fix-routes-removal branch from d009cb3 to 816304c Compare June 8, 2021 16:01
@rosik rosik merged commit aa67005 into master Jun 8, 2021
@rosik rosik deleted the fix-routes-removal branch June 8, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@yngvar-antonsson yngvar-antonsson yngvar-antonsson approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect http routes removal
2 participants
@rosik @yngvar-antonsson