cpu metrics: fix hot reload #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasiliy-t
force-pushed
the
gh-228-cpu-metrics-hotreload
branch
from
493d930 to
b79267b
Compare
vasiliy-t
changed the title
yngvar-antonsson
approved these changes
May 14, 2021
filonenko-mikhail
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPU metrics breaks hot reload. This caused by
ffi.cdef(struct...)- multiple calls with same definition results inattempt to redefine xxx....error. I introduced guard to check if those variables already defined.I didn't forget about
Close #228