Update ma_charsets #2
Conversation
Added the character sets and collations described in CONC-299. No additional test added, since charset/test_conc33 checks if all character sets and collations from server are supported. (cherry picked from commit fe129ed)
According to https://msdn.microsoft.com/en-us/library/windows/desktop/dd317756(v=vs.85).aspx code page for latin1 is 1252, and not 850. The same for some other collations. Changed "auto" charset detection to use only GetACP() on windows. Since I guess C/ODBC is the only user of that feature, and because GetConsoleCP() returns OEM codepage, and not the default system codepage, which is used by DM as source codepage for recoding to unicode. (cherry picked from commit 9a50a7d)
(cherry picked from commit 61ecc3b)
(cherry picked from commit e9a2c9e)
|
Did you consider to update the base downstream version to the latest upstream release? (Asked in PR #1, but didn't get an answer.) Anyway, backporting is okay for me too. I just want to understand how the decision was made. |
I thought about that, but it breaks tarantool/mysql, I think it's worth another task. For that particular issue just updating ma_charset is enough. |
There was a problem hiding this comment.
Thank you for the PR. Can you please provide a draft PR for mysql with charset test based on tarantool/mysql#47 ? It is rather hard to verify these changes by reviewing the code.
Yes, u can see it here, i dele ted workaround from ci for this bug, so u can see that ci is green without workaround. |
Updated compiled_charset_list prior to tarantool/mysql#47 in tarantool/mysql repo.