`server:start` continues to wait for a server start even after server exits with an error

[sergepetrenko]

Try this patch in main tarantool repo:

diff --git a/test/replication-luatest/gh_6123_truncate_temp_space_test.lua b/test/replication-luatest/gh_6123_truncate_temp_space_test.lua
index ee59449e1..a3ef17dca 100644
--- a/test/replication-luatest/gh_6123_truncate_temp_space_test.lua
+++ b/test/replication-luatest/gh_6123_truncate_temp_space_test.lua
@@ -12,7 +12,8 @@ g.before_each(function(cg)
             server.build_listen_uri('master')
         },
         replication_timeout = 1,
-        read_only           = false
+        read_only           = false,
+        no_such_option = true,
     }
 
     cg.master = cg.cluster:build_server({alias = 'master', box_cfg = box_cfg})

Observe the following results:

No output during 10 seconds. Will abort after 120 seconds without output. List of workers not reporting the status:
- 001_replication-luatest [replication-luatest/gh_6123_truncate_temp_space_test.lua, None] at /tmp/t/001_replication-luatest/gh_6123_truncate_temp_space.result:0
No output during 20 seconds. Will abort after 120 seconds without output. List of workers not reporting the status:
- 001_replication-luatest [replication-luatest/gh_6123_truncate_temp_space_test.lua, None] at /tmp/t/001_replication-luatest/gh_6123_truncate_temp_space.result:0
No output during 30 seconds. Will abort after 120 seconds without output. List of workers not reporting the status:
- 001_replication-luatest [replication-luatest/gh_6123_truncate_temp_space_test.lua, None] at /tmp/t/001_replication-luatest/gh_6123_truncate_temp_space.result:0
No output during 40 seconds. Will abort after 120 seconds without output. List of workers not reporting the status:
- 001_replication-luatest [replication-luatest/gh_6123_truncate_temp_space_test.lua, None] at /tmp/t/001_replication-luatest/gh_6123_truncate_temp_space.result:0
No output during 51 seconds. Will abort after 120 seconds without output. List of workers not reporting the status:
- 001_replication-luatest [replication-luatest/gh_6123_truncate_temp_space_test.lua, None] at /tmp/t/001_replication-luatest/gh_6123_truncate_temp_space.result:0
No output during 61 seconds. Will abort after 120 seconds without output. List of workers not reporting the status:
- 001_replication-luatest [replication-luatest/gh_6123_truncate_temp_space_test.lua, None] at /tmp/t/001_replication-luatest/gh_6123_truncate_temp_space.result:0
No output during 71 seconds. Will abort after 120 seconds without output. List of workers not reporting the status:
- 001_replication-luatest [replication-luatest/gh_6123_truncate_temp_space_test.lua, None] at /tmp/t/001_replication-luatest/gh_6123_truncate_temp_space.result:0
No output during 81 seconds. Will abort after 120 seconds without output. List of workers not reporting the status:
- 001_replication-luatest [replication-luatest/gh_6123_truncate_temp_space_test.lua, None] at /tmp/t/001_replication-luatest/gh_6123_truncate_temp_space.result:0
No output during 91 seconds. Will abort after 120 seconds without output. List of workers not reporting the status:
- 001_replication-luatest [replication-luatest/gh_6123_truncate_temp_space_test.lua, None] at /tmp/t/001_replication-luatest/gh_6123_truncate_temp_space.result:0
No output during 101 seconds. Will abort after 120 seconds without output. List of workers not reporting the status:
- 001_replication-luatest [replication-luatest/gh_6123_truncate_temp_space_test.lua, None] at /tmp/t/001_replication-luatest/gh_6123_truncate_temp_space.result:0
No output during 111 seconds. Will abort after 120 seconds without output. List of workers not reporting the status:
- 001_replication-luatest [replication-luatest/gh_6123_truncate_temp_space_test.lua, None] at /tmp/t/001_replication-luatest/gh_6123_truncate_temp_space.result:0
[001] replication-luatest/gh_6123_truncate_temp_spac>                 [ fail ]
[001] Test failed! Output from reject file /tmp/t/rejects/replication-luatest/gh_6123_truncate_temp_space.reject:
[001] Tarantool version is 2.11.0-entrypoint-819-gea5ff9cd6
[001] TAP version 13
[001] 1..2
[001] # Started on Wed Dec 21 18:48:07 2022
[001] # Starting group: gh_6123.engine:"memtx"
[001] master | ER_CFG: Incorrect value for option 'no_such_option': unexpected option
[001] master | fatal error, exiting the event loop
[001] replica | 'strip_core' is set but unsupported
[001] replica | 2022-12-21 18:48:11.208 [56304] main/103/server_instance.lua F> can't initialize storage: Incorrect value for option 'replication': failed to connect to one or more replicas
[001] not ok 1	gh_6123.engine:"memtx".test_truncate_is_local_transaction
[001] #   ...nko/Source/sptnt/test-run/lib/luatest/luatest/server.lua:318: Timed out to wait for "server is ready" condition for server (alias: master, workdir: master-ZjKF7T9y78VX, pid: 56296) within 60s
[001] #   stack traceback:
[001] #   	...replication-luatest/gh_6123_truncate_temp_space_test.lua:35: in function <...replication-luatest/gh_6123_truncate_temp_space_test.lua:7>
[001] #   	...
[001] #   	[C]: in function 'xpcall'
[001] # Starting group: gh_6123.engine:"vinyl"
[001] master | ER_CFG: Incorrect value for option 'no_such_option': unexpected option
[001] master | fatal error, exiting the event loop
[001] replica | 'strip_core' is set but unsupported
[001] replica | 2022-12-21 18:49:11.318 [56400] main/103/server_instance.lua F> can't initialize storage: Incorrect value for option 'replication': failed to connect to one or more replicas
[001] not ok 2	gh_6123.engine:"vinyl".test_truncate_is_local_transaction
[001] #   ...nko/Source/sptnt/test-run/lib/luatest/luatest/server.lua:318: Timed out to wait for "server is ready" condition for server (alias: master, workdir: master-L08OHhVKdJLC, pid: 56396) within 60s
[001] #   stack traceback:
[001] #   	...replication-luatest/gh_6123_truncate_temp_space_test.lua:35: in function <...replication-luatest/gh_6123_truncate_temp_space_test.lua:7>
[001] #   	...
[001] #   	[C]: in function 'xpcall'
[001] # Ran 2 tests in 120.237 seconds, 0 succeeded, 2 errored
[Main process] Got failed test; gently terminate all workers...
[001] Worker "001_replication-luatest" got failed test; stopping the server...