Use cmake build instead builtin #50
Conversation
|
I would prefer to use While I'm looking at it, I found that Please, wait a bit and I'll share all findings. |
XXX: luarocks removes `.git` directory after cloning a repository. So
actually this approach only works when we're within our cloned
repository. So, questions:
1. We need to reprase comments acoordingly at least.
2. Whether it works with tarantoolctl rocks install in CI?
Now it is possible to obtain a version of the module using the
following code:
```lua
local graphql = require('graphql')
print(graphql.VERSION)
```
It does not work for cloned repository (without calling `tarantoolctl
rocks make`) -- the `graphql.VERSION` field will return `'unknown'`, but
it works for a user scenario: when the module is installed either from
.all.rock file or from the rockspec.
The short list of changes is the following.
- Upload all.rock instead of .src.rock for releases. I don't find a way
to add a generated file into the .src.rock tarball using luarocks. It
is not necessary, though: it is completely okay (and even preferable)
to ship .all.rock for a pure Lua module.
- Upload scm-1 rockspec from CI.
- Moved from the `'builtin'` build type to `'make'` in the rockspec to
generate the `graphql/VERSION.lua` file at the build stage.
- Added Make targets for luarocks with `graphql/VERSION.lua` file
generation.
- Added `graphql/init.lua` file with `VERSION` field, which is filled
from the generated `graphql/VERSION.lua` file if it is present.
Otherwise it is filled with the `'unknown'` string.
And a couple of minor tweaks:
- Replaced `tarantoolctl rocks new_version --tag $TAG` with `sed` in the
rockspec publication workflow, because the former strips comments and
reformats the file. It is a thing of taste: personally I prefer to be
able to diff rockspecs on the rock server in case of an incident.
- Use `ubuntu-latest` in rockspec publication workflow, because we have
nothing Ubuntu version specific here. This way it requires less
maintenance.
The publication workflow now almost the same as in expirationd, see [1].
As for me, it is good to have such code standartized.
This is reimplementation of the original #29 fix from PR #41. The key
points are the following.
- Usage the `'make'` build type allows to lower the logic down to
luarocks level, so it works not only from CI.
- Complete the implementation by packing into .all.rock instead of
.src.rock. Otherwise it does not work at all, see [2] for details.
- Generate the gitignored `graphql/VERSION.lua` file (don't touch
`graphql/init.lua`) to don't leave the repository clone in a dirty
state.
Also it is the alternative to PR #50, where the `'cmake'` build type was
proposed for the same purposes. The differences are the following.
- Use Make instead of CMake for the same of simplicity.
- Don't require tarantool-dev/devel package for building the rock or
installing the package from the rockspec.
[1]: tarantool/expirationd#55
[2]: #46 (comment)
Follows up #29
Supersedes PR #50
|
I followed it up with a proposal in PR #53. Here you can find a brief description of all alternatives and a reason why I prefer to generate the version string from CI. In short: it is simple and explicit. |
|
I pushed my alternative and released graphql-0.1.4. I'm going to close this pull request, because the problem looks resolved. If you have any inputs, please, let me know. |
Seems it's time to move from builtin build type to cmake to make all the stall from the box.