Skip to content

Fix specifiedByUrl -> specifiedByURL #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Fix specifiedByUrl -> specifiedByURL #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions graphql/introspection.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,11 +346,11 @@ __Type = types.object({
end,
},

specifiedByUrl = {
specifiedByURL = {
kind = types.string,
resolve = function(kind)
if kind.__type == 'Scalar' then
return kind.specifiedByUrl
return kind.specifiedByURL
end
end,
},
Expand Down
2 changes: 1 addition & 1 deletion graphql/types.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ function types.scalar(config)
parseValue = config.parseValue,
parseLiteral = config.parseLiteral,
isValueOfTheType = config.isValueOfTheType,
specifiedByUrl = config.specifiedByUrl,
specifiedByURL = config.specifiedByURL,
}

instance.nonNull = types.nonNull(instance)
Expand Down
6 changes: 3 additions & 3 deletions test/integration/graphql_test.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1427,7 +1427,7 @@ function g.test_custom_directives()
t.assert_equals(errors, nil)
end

function g.test_specifiedByUrl_scalar_field()
function g.test_specifiedByURL_scalar_field()
local function callback(_, _)
return nil
end
Expand All @@ -1445,7 +1445,7 @@ function g.test_specifiedByUrl_scalar_field()
isValueOfTheType = function(_)
return true
end,
specifiedByUrl = 'http://localhost',
specifiedByURL = 'http://localhost',
})

local query_schema = {
Expand All @@ -1461,7 +1461,7 @@ function g.test_specifiedByUrl_scalar_field()
local data, errors = check_request(introspection.query, query_schema)
local CustomInt_schema = util.find_by_name(data.__schema.types, 'CustomInt')
t.assert_type(CustomInt_schema, 'table', 'CustomInt schema found on introspection')
t.assert_equals(CustomInt_schema.specifiedByUrl, 'http://localhost')
t.assert_equals(CustomInt_schema.specifiedByURL, 'http://localhost')
t.assert_equals(errors, nil)
end

Expand Down
2 changes: 1 addition & 1 deletion test/integration/introspection.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ return {
kind
name
description
specifiedByUrl
specifiedByURL
fields(includeDeprecated: true) {
name
description
Expand Down