-
Notifications
You must be signed in to change notification settings - Fork 43
Document logging configuration settings #4139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
179cb7a
to
59e3e00
Compare
b311842
to
a90ffcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
.. confval:: log.format | ||
|
||
Specify a format is used for a log entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specify a format is used for a log entry. | |
Specify a format that is used for a log entry. |
Example on GitHub: `log_level <https://github.com/tarantool/doc/tree/latest/doc/code_snippets/snippets/config/instances.enabled/log_level>`_. | ||
|
||
| | ||
| Type: number, string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The option here accepts both string and number as values, as stated in instance_config.lua
In the box.cfg reference, only the number is mentioned - is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The option here accepts both string and number as values, as stated in instance_config.lua
In the box.cfg reference, only the number is mentioned - is this correct?
Checked - also accepts string values. Also fixed string values that log_level
accepts (db007f8). For example, CRITICAL
is an incorrect value. Thanks!
Runnable samples/tests used in docs:
doc/code_snippets/snippets/config/instances.enabled/
directory, names start withlog_
).log_test.lua
used in thelog
module docs.Docs:
log
section in the configuration reference. Staging: https://docs.d.tarantool.io/en/doc/logging/reference/configuration/configuration_reference/#log.log
module API descriptions taking into account new config options. Staging: https://docs.d.tarantool.io/en/doc/logging/reference/reference_lua/log/.Logs
topic in theAdministration
section. Staging: https://docs.d.tarantool.io/en/doc/logging/book/admin/logs/.Changes not directly related to
log
settings - fixedaudit_log
samples:audit_log_pipe
had an incorrect value in theaudit_log.pipe
option.audit_log_syslog
had a broken cluster topology and an incorrect value in theaudit_log.filter
option (string instead of array).