[Config] Document 'memtx' configuration settings #4038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuniq
force-pushed
the
gh-4012-memtx-config
branch
from
2cc1028 to
ee4d094
Compare
xuniq
force-pushed
the
gh-4012-memtx-config
branch
2 times, most recently
from
fa05f18 to
e7a2d9d
Compare
Gumix
approved these changes
Mar 4, 2024
andreyaksenov
suggested changes
Mar 7, 2024
There was a problem hiding this comment.
Please see my comments below.
One important thing regarding a new option for specifying a number of sorting threads: this option replaces the legacy approach when OpenMP threads are used to parallelize sorting:
https://www.tarantool.io/en/doc/latest/concepts/atomic/thread_model/#supplementary-threads
So, we also need to update this section to using a new option and mention that the value of OMP_NUM_THREADS is still taken into account for backward compatibility (please double check).
xuniq
force-pushed
the
gh-4012-memtx-config
branch
from
81d1268 to
6021bcc
Compare
xuniq
force-pushed
the
gh-4012-memtx-config
branch
from
6021bcc to
d113f81
Compare
andreyaksenov
approved these changes
Mar 13, 2024
p7nov
pushed a commit
that referenced
this pull request
Apr 4, 2024
- Add `memtx` section in the Configuration reference - Add `memtx_sort_threads` option to the box.cfg reference and updated box.cfg reference - Add `In-memory storage` topic to the Configuration section - Update `Supplementary threads` topic and added a note about OpenMP threads deprecation - Fix some build warnings Fixes #4012 Fixes #3509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4012
Fixes #3509