graphql: strict type validation #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFAIR, query_util was extracted in graphql.0 to reuse it in avro_schema generation for a query. Maybe you don't need to move the code here. I had several non-standard types: Long, Map, InputUnion, InputMap. Please, verify that they don't leak here. Please also consider to to open a PR to https://github.com/tarantool/graphql. |
Will do |
olegrok
force-pushed
the
graphql-refactor
branch
3 times, most recently
from
708c8f4 to
76cb56d
Compare
olegrok
force-pushed
the
graphql-refactor
branch
from
76cb56d to
64e18a5
Compare
|
Related patch to https://github.com/tarantool/graphql - tarantool/graphql#7 |
Merged
olegrok
force-pushed
the
graphql-refactor
branch
2 times, most recently
from
a00090f to
f7fb3ed
Compare
rename "evaluateSelection" to "evaluateSelections" before we define global variable.
This patch is a port of tarantool/graphql.0@38fc560
To preserve backward compatibility
olegrok
force-pushed
the
graphql-refactor
branch
from
5b227b9 to
1edb5d4
Compare
rosik
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset is a port of tarantool/graphql.0#180 by @Totktonada
See commit messages for the references.
This patchset solves a problem then we don't validate arguments that are passed via variables for nullability-non-nullability