Make default building height 5 metres (1 story) #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I've seen this bug driving around in the suburbs with little outbuilding sheds. Good sleuthing! I need to review how this interacts with our push-pop zoom-dependent building extrusion logic but don't expect any problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When some buildings are mapped with 1 or 2 levels around an area, which seems to amount to 5 and 8 metres in the vector tiles, the default height of 20 metres (typically for sheds and garages, which StreetComplete isn't asking for levels for) towers over the other buildings.
I have submitted this PR for a more sensible 5 metre default for the building heights.