Use @tailwindcss/node for import in CLI#17502
Merged
Merged
Conversation
philipp-spiess
force-pushed
the
fix/cli-node-dep
branch
from
9f63f25 to
c61c54d
Compare
RobinMalfait
approved these changes
Apr 2, 2025
RobinMalfait
left a comment
RobinMalfait
left a comment
Member
There was a problem hiding this comment.
Running a local build of this branch does fix the problem. 💪
No more "jiti" in the bundle after this change.
Before:
After:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17501
Seems like an oversight. The CLI does have a dependency on
@tailwindcss/nodeso it should use it from the public import like the other stuff.Test plan
Looked at the minified
dist/output to ensure the import forjitiis gone