Add ::-webkit-details-marker pseudo to marker variant#17362
Merged
Conversation
thecrypticace
force-pushed
the
feat/webkit-details-marker
branch
from
dd9c8d6 to
6126a88
Compare
philipp-spiess
approved these changes
Mar 25, 2025
| @@ -623,7 +623,12 @@ export function createVariants(theme: Theme): Variants { | |||
| staticVariant('first-line', ['&::first-line']) | |||
|
|
|||
| // TODO: Remove alpha vars or no? | |||
Contributor
There was a problem hiding this comment.
Is this still relevant? I don't even know what this comment is trying to say so we might wanna remove it lol
Contributor
Author
There was a problem hiding this comment.
Yeah we should drop the comment
RobinMalfait
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #17360
This PR updates the
markervariant to also target the marker present in<summary>elements in WebKit browsers. Chromium uses::markerand is therefore already covered.