Properly skip over nodes when using replaceNode#16300
Merged
Merged
Conversation
philipp-spiess
force-pushed
the
fix/properly-handle-skip-with-replace
branch
from
4a7d014 to
32ca102
Compare
philipp-spiess
force-pushed
the
fix/properly-handle-skip-with-replace
branch
from
32ca102 to
39a5180
Compare
RobinMalfait
reviewed
Feb 6, 2025
RobinMalfait
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16298
This PR fixes an issue where using an AST walk in combination with
replaceNodeand variousSkipActionwould either cause children to be visited multiple times or not visited at all even though it should. This PR fixes the issue which also means we can get rid of a custom walk for@variantinside the@mediathat was used to apply@variantbecause we never recursively visited children inside the@mediarule.Because we now can use the regular walk for
@variant, we now properly convert@variantto@custom-variantinside@reference-ed stylesheet which also fixes #16298Test plan
Lots of tests added to ensure the combinations of
WalkActionandreplaceWith()works as expected.