Do not scan tailwind-merge sources for candidates#16005
Merged
Conversation
RobinMalfait
approved these changes
Jan 29, 2025
RobinMalfait
left a comment
RobinMalfait
left a comment
Member
There was a problem hiding this comment.
Should we add an integration test to ensure this works as expected (and keeps working in the future)?
Otherwise, I like it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #15722
This PR adds a list of ignored dependencies (in the current form only
tailwind-merge) to the Vite extension which, when included in the dependency tree, are no longer scanned by the Tailwind CSS compiler for candidates. This is to work around an issue where some dependencies contain vast lists of valid Tailwind CSS class names which would otherwise always be inlined in the build.Test plan
This was tested in our Vite playground on both dev and prod builds across macOS and Windows:
Windows prod build before
Windows prod build after
This includes a debug
console.log(…)to make sure it matches the right module.Windows dev build after
This includes a debug
console.log(…)to make sure it matches the right module.