Ensure font-size utilities with none modifier works e.g.: text-sm/none#15921
Merged
Conversation
If you used `text-sm/foobar`, then this would generate:
```css
.text-sm\/foobar {
font-size: var(--text-sm);
}
```
Even if the `/foobar` is not really used. This fixes that by ensuring
that if a modifier is used, but doesn't resolve, that it does not
generate any CSS.
`leading-none` is a hardcoded value, and is not coming from the `@theme`. This means that this is the only modifier value you can't use with a `text-*` utility. E.g.: `text-sm/none` will not have a `line-height: 1;` attached.
RobinMalfait
force-pushed
the
fix/issue-15911
branch
from
15a47fc to
f112350
Compare
This was referenced Jan 27, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where classes such as
text-sm/nonedon't work as expected. The reason for this is thatleading-noneis the only hardcoded leading utility and is not coming from the@theme. This means thattext-sm/nonetries to do a lookup fornonebut it won't resolve.This PR fixes that by allowing
noneas a modifier.While working on this, I noticed that
text-sm/nonedid generate CSS:Notice that the
line-heightis missing. This means that any modifier that can't be resolved doesn't get theline-heightset, but it will generate CSS. In this case, no CSS should have been generated.Otherwise, all of these generate CSS which will only bloat your CSS and won't
work as expected. E.g.:
text-sm/foo,text-sm/bar, andtext-sm/baz:Fixes: #15911