Optimize AST before printing for IntelliSense#15347
Merged
Merged
Conversation
thecrypticace
force-pushed
the
fix/v4-intellisense-css-printing
branch
from
489b836 to
e60cbd4
Compare
RobinMalfait
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We changed how AST printing worked recently but forgot to update this. Which causes us to print properties with a value of
undefinedin Tailwind Play, Tailwind CSS IntelliSense, and our Language Server (oops):This PR fixes this by optimizing the AST before printing (which is what toCss did previously)