Improve root file detection#15048
Merged
Merged
Conversation
Instead of trying to be smart, let's keep checking for common root files among the common parents until we don't find common parents anymore.
thecrypticace
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the Tailwind root file detection was wrong.
Whenever a CSS file contains any of the
@tailwinddirectives or an@importto any of the Tailwind files, the file is considered a Tailwind root file.If multiple CSS files are part of the same tree, then we make the nearest common parent the root file.
This root file will be the file where we add
@configand/or inject other changes during the migration process.However, if your folder structure looked like this:
Then we computed that
index.cssnadbase.csswere considered root files even though they belong to the same tree (becausebase.cssis imported byindex.css).This PR fixes that behaviour by essentially being less smart, and just checking again if any sheets are part of the same tree.
Test plan:
Added an integration test that covers this scenario and fails before the fix.
Also ran it on our tailwindcss.com codebase.
(Yes, I know the migration still fails, but that's a different issue.)