Upgrade: Error when project is already using Tailwind CSS v4#15015
Merged
Conversation
RobinMalfait
requested changes
Nov 15, 2024
philipp-spiess
force-pushed
the
feat/check-tw-version-before-upgrade
branch
from
f942429 to
194f4f2
Compare
RobinMalfait
requested changes
Nov 18, 2024
RobinMalfait
left a comment
RobinMalfait
left a comment
Member
There was a problem hiding this comment.
Also needs a changelog entry
Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
RobinMalfait
force-pushed
the
feat/check-tw-version-before-upgrade
branch
from
1d716c4 to
71ce1fa
Compare
RobinMalfait
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some local testing we ran the
@tailwindcss/upgradecommand twice in a row. It would be great to get some feedback that this is not working, so this PR now checks if it can resolve the installed version oftailwindcssand if it can, it requires it to be < 4 (you can bypass this check with--force).