Bring back max-w-screen-* utilities#15013
Merged
Merged
Conversation
philipp-spiess
force-pushed
the
feat/max-w-screen
branch
from
418177e to
e143040
Compare
adamwathan
reviewed
Nov 16, 2024
adamwathan
approved these changes
Nov 16, 2024
adamwathan
force-pushed
the
feat/max-w-screen
branch
from
4226132 to
912c69e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings back the
max-w-screen-*utilities from v3 that read from the--breakpointnamespace.Since these utilities are only added back for compatibility reasons, it's put into the compatibility layer.
Note that this does not do Intellisense recommendations for the functional utility.
Test Plan
Unit tests are upgraded including some from the compat test that extends the
--breakpointnamespace fromscreenkeys. Also tested this in the Vite playground.