Upgrade: Improve heuristics around important codemod#14774
Merged
adamwathan merged 2 commits intoOct 24, 2024
Conversation
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @philipp-spiess and the rest of your teammates on |
philipp-spiess
force-pushed
the
10-24-upgrade_improve_heuristics_around_important_codemod
branch
2 times, most recently
from
9bce67f to
6b28e58
Compare
adamwathan
reviewed
Oct 24, 2024
Co-authored-by: Adam Wathan <adam.wathan@gmail.com>
philipp-spiess
force-pushed
the
10-24-upgrade_improve_heuristics_around_important_codemod
branch
from
ddee4c6 to
8abbc77
Compare
adamwathan
approved these changes
Oct 24, 2024
adamwathan
deleted the
10-24-upgrade_improve_heuristics_around_important_codemod
branch
chloepriceless
added a commit
to chloepriceless/proxmox-gui
that referenced
this pull request
May 14, 2026
Tailwind v4's oxide Rust backend needs @tailwindcss/oxide-linux-x64-gnu as a sibling at runtime. pnpm 11.1.1 with default 'isolated' linker sometimes fails to create the required nested symlink in .pnpm/@tailwindcss+oxide/node_modules/@tailwindcss/, even though the platform package is installed in the store. Known issue: github.com/tailwindlabs/tailwindcss/issues/14774. Fix: write 'node-linker=hoisted' to frontend/.npmrc before pnpm install. This switches pnpm to npm-style flat node_modules layout, so require('@tailwindcss/oxide-linux-x64-gnu') resolves the way every npm tool expects. Verified local layout (isolated linker, works there): node_modules/.pnpm/@tailwindcss+oxide@4.3.0/node_modules/@tailwindcss/ ├── oxide/ (main package) └── oxide-linux-x64-gnu -> ../../../@tailwindcss+oxide-linux-x64-gnu@.../... In the LXC the second entry was missing despite '+338 packages' being reported by pnpm — silent skip of the platform optional dep symlink. Hoisted layout sidesteps the bug entirely. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the heuristics around the important codemod (e.g.
!border=>border!) as we noticed a few more cases where we the current heuristics was not enough.Specifically, we made it not migrate the candidate in the following conditions:
{ "foo": !border.something + ""}<div v-if="something && !border"></div>or<div x-if="!border"></div>Test plan
I added test cases to the unit tests and updated the integration test to contain a more sophisticated example.