Upgrade: Migrate max-w-screen-* candidates#14754
Merged
graphite-app[bot] merged 1 commit intoOct 22, 2024
Merged
Conversation
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @philipp-spiess and the rest of your teammates on |
philipp-spiess
force-pushed
the
10-22-upgrade_migrate_max-w-screen-_candidates
branch
2 times, most recently
from
082b42d to
48dad29
Compare
| import { automaticVarInjection } from './codemods/automatic-var-injection' | ||
| import { bgGradient } from './codemods/bg-gradient' | ||
| import { important } from './codemods/important' | ||
| import { maxWScreen } from './codemods/max-w-screen' |
Contributor
There was a problem hiding this comment.
Can we call this maxWidthScreen instead?
Contributor
Author
There was a problem hiding this comment.
yeah we should
philipp-spiess
force-pushed
the
10-22-upgrade_migrate_max-w-screen-_candidates
branch
from
48dad29 to
b63f791
Compare
RobinMalfait
approved these changes
Oct 22, 2024
Contributor
Author
Merge activity
|
This PR migrates `max-w-screen-*` candidates to the v4 equivalent relying on the breakpoint var: `max-w-[var(--breakpoint-*)]`
RobinMalfait
force-pushed
the
10-22-upgrade_migrate_max-w-screen-_candidates
branch
from
0d9b6d0 to
fc261bd
Compare
graphite-app
Bot
deleted the
10-22-upgrade_migrate_max-w-screen-_candidates
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates
max-w-screen-*candidates to the v4 equivalent relying on the breakpoint var:max-w-[var(--breakpoint-*)]