Always emit keyframes registered in addUtilities#14747
Merged
graphite-app[bot] merged 1 commit intoOct 22, 2024
Merged
Conversation
Member
|
Wonder if all we actually need to do is revert this one line change? Do |
Contributor
|
Ahhh... of course. 🤕 We should probably add a test in the plugin-api spec for this that only uses I’m with @adamwathan here in that this feels like it should go directly in the CSS. This way we can also keep the core layer pristine. |
Contributor
Author
|
Ah yeah directly inserting into the AST seems more reasonable. I'll make that change. Ditto w/ addBase + tests |
4d8841b to
bb1a981
Compare
philipp-spiess
approved these changes
Oct 22, 2024
Contributor
Merge activity
|
Fixes #14732 cc @philipp-spiess this look like an okay fix?
35d2bb2 to
c0f2922
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14732
cc @philipp-spiess this look like an okay fix?