Ensure we migrate theme(spacing.1) to var(--spacing-1) correctly#14723
Closed
RobinMalfait wants to merge 1 commit into
Closed
Ensure we migrate theme(spacing.1) to var(--spacing-1) correctly#14723RobinMalfait wants to merge 1 commit into
theme(spacing.1) to var(--spacing-1) correctly#14723RobinMalfait wants to merge 1 commit into
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @RobinMalfait and the rest of your teammates on |
RobinMalfait
changed the base branch from
robin/simplify_candidate_printing
to
next
`theme(spacing.1)` wasn't converted because we generated `--spacing-` and that doesn't exist therefore we kept it as-is.
RobinMalfait
force-pushed
the
robin/ensure_we_migrate_theme_spacing.1_correctly
branch
from
73d0024 to
aa19114
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
theme(…)calls that contain a.1weren't correctly converted tovar(--spacing-1). The reason for this is that.1has some special meaning in cases likefontSize.xs.1.lineHeightwhere it should be converted to--font-size-xs--line-height, not--font-size-xs-1-line-height.To solve this, we make sure to only apply the
--check if the1occurs somewhere in the middle instead of at the very end.With this change, the following migrations will happen correctly: