Fix CLI client crash when a file is removed before we process the change notification#14616
Merged
Conversation
philipp-spiess
force-pushed
the
fix/postcss-client-crash
branch
2 times, most recently
from
e076e5f to
356fe9d
Compare
philipp-spiess
requested review from
RobinMalfait,
adamwathan and
thecrypticace
thecrypticace
suggested changes
Oct 8, 2024
thecrypticace
left a comment
thecrypticace
left a comment
Contributor
There was a problem hiding this comment.
nit: the PR title is wrong — this is about the CLI
philipp-spiess
changed the title
… change notification
Co-authored-by: Jordan Pittman <jordan@cryptica.me>
philipp-spiess
force-pushed
the
fix/postcss-client-crash
branch
from
58030df to
dfbfb78
Compare
thecrypticace
suggested changes
Oct 9, 2024
thecrypticace
left a comment
thecrypticace
left a comment
Contributor
There was a problem hiding this comment.
The changelog has some extra stuff in it
Contributor
Author
|
@thecrypticace how the hell 🫠 cursed PR |
Contributor
Author
|
@thecrypticace most changes were actually intended to fix some conflicts that are in main right now but there was one unnecessary duplicate from a previous version somehow 🤷 |
philipp-spiess
commented
Oct 9, 2024
thecrypticace
approved these changes
Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14613
Don't crash when trying to read the modification time of a file that might already be deleted.
Note: This fix is purely theoretical right now as I wasn't able to reproduce the issue yet.