Migrate simple PostCSS setup#14612
Merged
Merged
Conversation
c87d7d6 to
d2662d8
Compare
RobinMalfait
reviewed
Oct 7, 2024
RobinMalfait
left a comment
Member
There was a problem hiding this comment.
We have some failing tests 🤔
Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
e5934fb to
7494dd8
Compare
philipp-spiess
commented
Oct 8, 2024
philipp-spiess
left a comment
Contributor
Author
There was a problem hiding this comment.
Some comments from my call with @RobinMalfait that I will fix up 👍
philipp-spiess
commented
Oct 8, 2024
philipp-spiess
commented
Oct 8, 2024
thecrypticace
previously requested changes
Oct 9, 2024
thecrypticace
left a comment
Contributor
There was a problem hiding this comment.
Just a couple things but otherwise looks good!
60fde28 to
ffd7417
Compare
thecrypticace
approved these changes
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to detect simple postcss setups: These are setups that do not load dynamic modules and are based off the examples we are recommending in our docs. We detect wether a config is appropriate by having it use the object plugin config and by not requiring any other modules:
When we find such a config file, we will go over it line-by-line and attempt to:
tailwindcss:to'@tailwindcss/postcss':autoprefixerif usedWe then attempt to install and remove the respective npm packages based on the package manger we detect.
And since we now have logic to upgrade packages, this also makes sure to install
tailwindcss@nextat the end of a sucessful migration.