Fix @apply and CSS functions inside imported files#14576
Merged
Conversation
philipp-spiess
requested review from
RobinMalfait,
adamwathan and
thecrypticace
thecrypticace
approved these changes
Oct 3, 2024
| if (css.includes('@apply')) { | ||
| substituteAtApply(ast, designSystem) | ||
| } | ||
| substituteAtApply(ast, designSystem) |
Contributor
There was a problem hiding this comment.
I had a feeling we were going to have to do this eventually
adamwathan
reviewed
Oct 3, 2024
adamwathan
reviewed
Oct 3, 2024
adamwathan
force-pushed
the
fix/at-apply-for-imported-files
branch
from
2894c2e to
3e0b2c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part-of #14558
After handling
@importof stylesheets in core, we can no longer gate out features based on finding a specific sequence in the input CSS, as this string will not contain contents from other stylesheets.So, consider the following input CSS:
We can't opt-out of the traversal to search for
@applybased on it because it, of course, does not contain the contents of./styles.cssyet.