Add blocklist support from v3 config files#14556
Merged
Merged
Conversation
Contributor
Author
|
I'll fix the changelog conflict when we're ready to merge. |
RobinMalfait
approved these changes
Sep 30, 2024
RobinMalfait
left a comment
Member
There was a problem hiding this comment.
Nice! Can we add a test to make sure that @apply bg-white also doesn't work?
This is what v3 does: https://play.tailwindcss.com/ewH6tmV5q4?file=css
0ba85df to
ff7eb0e
Compare
Contributor
Author
|
Good call — I fixed that case and added a test for it. |
Contributor
Author
|
I think there's some wiggle room in the future here such that blocklist only applies to generated candidates. This is because the nature of content scanning means you're likely scanning content you can't change for the sake of Tailwind. But |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
blocklistconfig option when using a JS config file in v4. You can now block certain classes from being generated at all. This is useful in cases where scanning files sees things that look like classes but are actually not used. For example, in paragraphs in a markdown file:Output: