CLI: Use the right base when loading files from stdin#14522
Merged
Conversation
philipp-spiess
requested review from
RobinMalfait,
adamwathan and
thecrypticace
philipp-spiess
force-pushed
the
fix/base-for-cli-when-read-from-stdin
branch
from
676a362 to
98fe613
Compare
thecrypticace
approved these changes
Sep 26, 2024
Contributor
|
We should add a test for this if we can |
Contributor
Author
|
@thecrypticace added ✅ |
Contributor
|
@philipp-spiess I think the test should have a relative import to correctly catch this case yeah? |
Contributor
|
ah wait nvm this test is sufficient b/c the import for tailwind would fail too b/c node_modules in a different dir. LGTM |
thecrypticace
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14521
When using the CLI to read files from
stdinlike this:npx tailwindcss --input=- -o bar.css < foo.cssWe need to set the
basepath to be the current working directory (process.cwd()). However,cwd()already is a directory and callingdirname()on it did go to the parent directory _which might not have thetailwindcssdependency installed.