Move opacity modifier support into plugin theme() function#14348
Merged
Conversation
5d84d73 to
73368bd
Compare
RobinMalfait
approved these changes
Sep 5, 2024
RobinMalfait
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves support for opacity modifies from the CSS
theme()function into the plugintheme()implementation, this will allow plugins to use this, too:There's a small behavioral change for the CSS
theme()function. Since tuples are resolved by default for the CSStheme()function only, these will no longer have opacity applied to their first values. This is probably fine given the reduced complexity as I don't expect the first values of tuples to be colors and the fix would mean we would have to parse the modifier in different places.