switch to composite build and add api key check#28
Merged
willnorris merged 2 commits intomainfrom Jan 29, 2024
Merged
Conversation
Go is already installed on GitHub Action runners, so this simplifies our action slightly by removing Docker. More importantly, it allows us to run other steps such as validating inputs, similar to what we do in tailscale/github-action. Signed-off-by: Will Norris <will@tailscale.com>
This is effectively a noop right now, since the api-key input is required. This is in preparation for merging #24 where you can specify an api-key or oauth credentials. Signed-off-by: Will Norris <will@tailscale.com>
DentonGentry
approved these changes
Jan 29, 2024
| exit 1 | ||
| - uses: actions/setup-go@v4.0.0 | ||
| with: | ||
| go-version: 1.21.6 |
Contributor
There was a problem hiding this comment.
I'd recommend referencing the go.mod file so as to not have to increment this manually:
- name: Install Go
uses: actions/setup-go@v4
with:
go-version-file: go.mod
cache: false
Member
Author
There was a problem hiding this comment.
There is no go.mod file in this repo, and I don't think we can reference the one from tailscale/tailscale
Contributor
There was a problem hiding this comment.
Oh this isn't OSS. There isn't a go.mod. Never mind.
|
@willnorris Hey! This seems to break on our self hosted runners: Not sure if we should just allow our gh user access to |
|
As an alternative solution, I'm running the workflow in a container instead: |
willnorris
added a commit
that referenced
this pull request
Mar 21, 2024
Self-hosted runners sometimes can't write the built binary to /usr/local/bin, so just use `go run` instead. Updates #28 Signed-off-by: Will Norris <will@tailscale.com> Co-authored-by: Mario Minardi <mario@tailscale.com>
willnorris
added a commit
that referenced
this pull request
Mar 21, 2024
Self-hosted runners sometimes can't write the built binary to /usr/local/bin, so just use `go run` instead. Updates #28 Signed-off-by: Will Norris <will@tailscale.com> Co-authored-by: Mario Minardi <mario@tailscale.com>
willnorris
added a commit
that referenced
this pull request
Mar 21, 2024
Self-hosted runners sometimes can't write the built binary to /usr/local/bin, so just use `go run` instead. Updates #28 Signed-off-by: Will Norris <will@tailscale.com> Co-authored-by: Mario Minardi <mario@tailscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prepares for merging #24. Manually tested in a private repo on a test tailnet.