[Gui] Add scroll event and additional key constants to GGUI events#8784
Open
Azmisov wants to merge 2 commits intotaichi-dev:masterfrom
Open
[Gui] Add scroll event and additional key constants to GGUI events#8784Azmisov wants to merge 2 commits intotaichi-dev:masterfrom
Azmisov wants to merge 2 commits intotaichi-dev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds additional GLFW event integration for the new GGUI interface:
get_events, instead users rely on polling the current mouse position. I follow this same pattern, where scroll delta can be polled usingget_scroll_delta.Note
Medium Risk
Touches low-level GLFW input plumbing and changes how unknown key codes are surfaced (now emitting
Key_<id>events instead of dropping them), which could affect event handling for some apps. Overall scope is contained to GGUI input and Python bindings.Overview
Adds scroll-wheel support to GGUI by wiring GLFW scroll callbacks through
InputHandler/WindowBaseand exposing a new poll-style Python APIWindow.get_scroll_delta()(via pybind) that returns accumulated(dx, dy)and resets after read.Expands supported key constants (function, navigation, numpad) on both the C++ and Python sides, improves digit key name/id conversion, and changes unknown key handling to produce events with a
Key_<id>string instead of throwing/dropping the event.Written by Cursor Bugbot for commit 087062c. This will update automatically on new commits. Configure here.