-
Notifications
You must be signed in to change notification settings - Fork 13
Housekeeping: Upgrade dependencies #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the @modelcontextprotocol SDK and inspector dependencies and makes corresponding adjustments to avoid generating a requestId internally by instead requiring it as a parameter. Key changes include updating function signatures and tests to accept an external requestId, as well as removing the dependency on generating a random UUID within the tool logic.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/tools/tool.ts | Updated callback and logInvocation signatures to require a requestId. |
src/tools/tool.test.ts | Removed randomUUID mocks and updated expected log messages. |
src/tools/readMetadata.ts | Adjusted callback signature to accept the external requestId. |
src/tools/readMetadata.test.ts | Updated test expectations to match the external requestId usage. |
src/tools/queryDatasource/*.ts | Updated callback and error handling to use requestId appropriately. |
src/tools/listFields*.ts | Adjusted callback signature and updated requestId usage accordingly. |
src/tools/listDatasources/listDatasources.ts | Updated callback and requestId conversion in restApi instance creation. |
src/logging/log*.ts | Changed getToolLogMessage to accept an object with a requestId property. |
package.json | Upgraded dependency versions as outlined in the PR description. |
Comments suppressed due to low confidence (2)
src/tools/tool.ts:24
- Update the documentation and comments for LogAndExecuteParams and callback functions to reflect that the callback no longer receives a requestId, and that the requestId should be provided externally.
requestId: RequestId;
src/tools/tool.ts:86
- [nitpick] Consider adding a brief comment near the callback invocation to clarify that the requestId is now used separately, ensuring that future developers are aware of the design change.
const result = await callback();
These changes:
@modelcontextprotocol/sdk
to 1.12.1.requestId
to handlers via metadata modelcontextprotocol/typescript-sdk#358 so now we don't have to generate arequestId
ourselves.@modelcontextprotocol/inspector
to 0.14.0.