Skip to content

Housekeeping: Upgrade dependencies #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 6, 2025
Merged

Conversation

anyoung-tableau
Copy link
Collaborator

@anyoung-tableau anyoung-tableau commented Jun 6, 2025

These changes:

  1. Upgrade @modelcontextprotocol/sdk to 1.12.1.
  2. Upgrade @modelcontextprotocol/inspector to 0.14.0.
image

@anyoung-tableau anyoung-tableau changed the title Upgrade MCP SDK and MCP Inspector Housekeeping: Upgrade dependencies Jun 6, 2025
@anyoung-tableau anyoung-tableau marked this pull request as ready for review June 6, 2025 17:33
@Copilot Copilot AI review requested due to automatic review settings June 6, 2025 17:33
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the @modelcontextprotocol SDK and inspector dependencies and makes corresponding adjustments to avoid generating a requestId internally by instead requiring it as a parameter. Key changes include updating function signatures and tests to accept an external requestId, as well as removing the dependency on generating a random UUID within the tool logic.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/tools/tool.ts Updated callback and logInvocation signatures to require a requestId.
src/tools/tool.test.ts Removed randomUUID mocks and updated expected log messages.
src/tools/readMetadata.ts Adjusted callback signature to accept the external requestId.
src/tools/readMetadata.test.ts Updated test expectations to match the external requestId usage.
src/tools/queryDatasource/*.ts Updated callback and error handling to use requestId appropriately.
src/tools/listFields*.ts Adjusted callback signature and updated requestId usage accordingly.
src/tools/listDatasources/listDatasources.ts Updated callback and requestId conversion in restApi instance creation.
src/logging/log*.ts Changed getToolLogMessage to accept an object with a requestId property.
package.json Upgraded dependency versions as outlined in the PR description.
Comments suppressed due to low confidence (2)

src/tools/tool.ts:24

  • Update the documentation and comments for LogAndExecuteParams and callback functions to reflect that the callback no longer receives a requestId, and that the requestId should be provided externally.
  requestId: RequestId;

src/tools/tool.ts:86

  • [nitpick] Consider adding a brief comment near the callback invocation to clarify that the requestId is now used separately, ensuring that future developers are aware of the design change.
      const result = await callback();

Copy link

github-actions bot commented Jun 6, 2025

Code Coverage

Package Line Rate Branch Rate Health
src 90% 92%
src.logging 96% 92%
src.tools 99% 96%
src.tools.listDatasources 97% 86%
src.tools.queryDatasource 100% 100%
src.tools.queryDatasource.validators 99% 97%
src.utils 100% 100%
Summary 97% (1095 / 1134) 95% (283 / 297)

@anyoung-tableau anyoung-tableau merged commit 6be754c into main Jun 6, 2025
3 checks passed
@anyoung-tableau anyoung-tableau deleted the anyoung/versions branch June 6, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants