Skip to content

1580 list extracts on schedule #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 14, 2025
Merged

1580 list extracts on schedule #1604

merged 6 commits into from
May 14, 2025

Conversation

casey-crawford-cfa
Copy link
Contributor

No description provided.

@salesforce-cla Salesforce CLA
Copy link

salesforce-cla bot commented May 8, 2025

Thanks for the contribution! Before we can merge this, we need @casey-crawford-cfa to sign the Salesforce Inc. Contributor License Agreement.

@casey-crawford-cfa casey-crawford-cfa mentioned this pull request May 8, 2025
Closed
@casey-crawford-cfa
Copy link
Contributor Author

You already signed the CLA on 2025-05-08

I don't see the check getting updated though?

@bcantoni bcantoni closed this May 8, 2025
@bcantoni bcantoni reopened this May 8, 2025
@bcantoni
Copy link
Contributor

bcantoni commented May 8, 2025

I closed and reopened the PR the trigger the CLA bot and it seems happy now.

@bcantoni
Copy link
Contributor

@casey-crawford-cfa looks like you'll need one more pass with black formatting changes, then it should be green checks.

@jacalata could you please help with a code review here on this approach?

jacalata
jacalata approved these changes May 13, 2025
View reviewed changes
@jacalata
Copy link
Contributor

I'm guessing you have a different version of black locally which is causing the formatting checks to fail in our CI run. In our run I can see this version: (https://github.com/tableau/server-client-python/actions/runs/15007554051/job/42173973943?pr=1604)

Collecting black==24.8 (from tableauserverclient==0.post0.dev1)

@casey-crawford-cfa
Copy link
Contributor Author

Updated the PR from @jacalata 's comments, and reformatted with proper version of black.

@jacalata jacalata merged commit f9bc99b into tableau:development May 14, 2025
22 checks passed
@casey-crawford-cfa casey-crawford-cfa deleted the 1580-list-extracts-on-schedule branch May 15, 2025 13:08
jacalata added a commit that referenced this pull request May 15, 2025
@jacalata @jorwoods
@bcantoni @casey-crawford-cfa
v0.38 - IDP configuration (#1606)
cda018b 
* docs: docstrings for schedules and intervals (#1528)
* docs: Docstrings for new fields

* feat: enable retrieving only owned workbooks
* feat: Add support for multiple IDPs (jorwoods)
* feat: Add fields:_all_ support (#1563)
* feat: project support all fields
* feat: groups all fields
* feat: views support all fields
* feat: user support _all_ fields 
* feat: workbook support all fields
* feat: datasourceitem _all_ fields
* feat: add fields methods to QuerySet
* feat: add owner attribute to project
* Add SSL option for connecting to Tableau Server with a weaker DH key length
Fixes #1582
* feat: 1580 list extracts on schedule (#1604)

* chore: type hint database and table objects (#1593)
* ci: Switch Slack action to use `ubuntu-latest` like our other actions.
---------

Co-authored-by: Jordan Woods <[email protected]>
Co-authored-by: Jordan Woods <[email protected]>
Co-authored-by: Brian Cantoni <[email protected]>
Co-authored-by: casey-crawford-cfa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacalata jacalata jacalata approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@casey-crawford-cfa @bcantoni @jacalata