fix: Disallow subscribing to values of the wrong kind #6934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, PUT /attributes lets you subscribe to a value of the wrong kind. Since Claude is doing a lot of PUT /attributes, we need that not to work (because sometimes it makes mistakes, and some of those mistakes can mess up the workspace, including subscribing from a non-secret to a secret.)
array -> string / array -> object subscriptions are disallowed the same way; as such, this PR also removes the long-deprecated automatic
si:normalizeToArray
function in subscriptions (since now all you can do is array-to-array). There is no way in the UI to subscribe from an array to a single value, so this should not cause problems in the UI. We have left thekeepExistingSubscriptions
parameter in the API until we're sure clients have transitioned, but it's ignored and is no longer in tests or docs.Out of Scope:
How was it tested?
/resource_value
, it gets a reasonable error back and then corrects itself.In short: 🔗