Fix Docker image build #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Mar 1, 2025
jserv
reviewed
Mar 1, 2025
jserv
reviewed
Mar 1, 2025
| @@ -1,21 +1,24 @@ | |||
| FROM alpine:3.19 AS base_gcc | |||
|
|
|||
| RUN apk add --update alpine-sdk git wget | |||
| RUN apk add --update alpine-sdk git wget sdl2-dev sdl2_mixer-dev | |||
There was a problem hiding this comment.
The primary reason for excluding SDL2 packages from the current Alpine Linux image is to maintain a smaller image size, which enables quicker startup and emulation through blink or similar emulators. Including SDL2 in the Alpine Linux image would create challenges when attempting to run graphics with the emulator.
|
I defer to @henrybear327 for confirmation. |
ChinYikMing
force-pushed
the
fix-docker-build
branch
from
d7ad9a5 to
3e2d6a9
Compare
Commit a40fd0b adds objects file that built with the lib of SDL2 and SDL2_mixer for linker when building rv_histogram, the current Docker image lacks of SDL2 and SDL2_mixer shared objects, so installing them to fix the missing shared objects. The final Docker image size changes from around 4 MiB -> 28 MiB.
End of support of Alpine Linux v3.19.x is on 1 Nov 2025. Check: https://alpinelinux.org/releases/
ChinYikMing
force-pushed
the
fix-docker-build
branch
from
3e2d6a9 to
37c9838
Compare
|
Thank @ChinYikMing for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit a40fd0b adds objects file that built with the lib of SDL2 and SDL2_mixer for linker when building rv_histogram, the current Docker image lacks of SDL2 and SDL2_mixer shared objects, so installing them to fix the missing shared objects.
The final Docker image size changes from around 4 MiB -> 28 MiB.
Summary by Bito
This pull request enhances the Dockerfile for the rv_histogram application by upgrading to Alpine 3.21 and adding SDL2 libraries, addressing missing shared objects and increasing the image size from 4 MiB to 28 MiB.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2 - The changes are straightforward and primarily involve dependency updates, making the review process relatively simple.