Skip to content

feat(ip filter) Add ip filter resource for both monitor and secure #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 9, 2024
Merged

feat(ip filter) Add ip filter resource for both monitor and secure #534

merged 14 commits into from
Sep 9, 2024

Conversation

vojindj
Copy link
Collaborator

@vojindj vojindj commented Jul 23, 2024

No description provided.

@vojindj vojindj requested review from filiptubic and Shadow649 July 23, 2024 14:07
filiptubic
filiptubic reviewed Jul 24, 2024
View reviewed changes
filiptubic
filiptubic reviewed Jul 24, 2024
View reviewed changes
filiptubic
filiptubic reviewed Jul 24, 2024
View reviewed changes
@vojindj vojindj changed the title feat(allowed ip range) Add allowed ip range resource for both monitor and secure SP-3101 feat(allowed ip range) Add allowed ip range resource for both monitor and secure Jul 31, 2024
@vojindj vojindj changed the title feat(allowed ip range) Add allowed ip range resource for both monitor and secure feat(ip filter) Add ip filter resource for both monitor and secure Jul 31, 2024
@vojindj vojindj force-pushed the SP-3101_add_allowed_ip_range_resource branch from b6d3123 to 279f7cb Compare September 3, 2024 11:34
@vojindj vojindj marked this pull request as ready for review September 5, 2024 07:54
@vojindj vojindj force-pushed the SP-3101_add_allowed_ip_range_resource branch from 9cb65f2 to aa9fb45 Compare September 5, 2024 08:13
dbonf
dbonf approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@dbonf dbonf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I get that we are not able to test the write path of sysdig_ip_filtering_settings with enabled=true in integration tests otherwise we cut ourself out of the environment, we can live with that.

@vojindj vojindj merged commit 779e9c0 into master Sep 9, 2024
23 checks passed
@vojindj vojindj deleted the SP-3101_add_allowed_ip_range_resource branch September 9, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiptubic filiptubic filiptubic left review comments

@Shadow649 Shadow649 Shadow649 approved these changes

@dbonf dbonf dbonf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vojindj @Shadow649 @filiptubic @dbonf