Skip to content

Updating validation for the Sysdig public API url #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2025
Merged

Conversation

S3B4SZ17
Copy link
Collaborator

@S3B4SZ17 S3B4SZ17 commented Jul 31, 2025

Updating regex validation for the Sysdig public API url

Changes

  • Updating regex validation for the Sysdig public API url

  • Adding tests for the different URL formats

    Client is expecting the public API URL in the format https://api.{region}.sysdig.com. We will check the following:

    • A valid Sysdig host URL is provided by matching the expected patterns with a regex.
    • If not, we will try to fetch the public API URL from the app config yaml 'sysdig.public_api_url'.
    • If neither is available, we will raise an error.

@S3B4SZ17 S3B4SZ17 requested a review from a team as a code owner July 31, 2025 17:18
@S3B4SZ17 S3B4SZ17 force-pushed the fix/url-patterns branch 2 times, most recently from 774f6d3 to 25cf109 Compare July 31, 2025 18:55
alecron
alecron previously approved these changes Aug 1, 2025
Copy link
Collaborator

@alecron alecron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@S3B4SZ17 S3B4SZ17 merged commit ca0a0e1 into main Aug 1, 2025
4 checks passed
@S3B4SZ17 S3B4SZ17 deleted the fix/url-patterns branch August 1, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants