Fix SfPicker OK button disappearing after first click in dialog mode #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OK button in the SfPicker footer would become invisible after the first click when using dialog mode, though the tap gesture would still work in the invisible area. This was caused by insufficient validation logic in the
AddConfirmButton()method that could result in the button being removed from the UI while maintaining object references.Root Cause
The issue was in the
FooterLayout.AddConfirmButton()method which had this logic:In certain scenarios (such as after dialog close/reopen cycles), the button could be removed from the
Childrencollection but the_confirmButtonViewreference would remain, causing subsequent calls to return early without ensuring the button was actually visible in the UI.Solution
Enhanced the validation logic to check both the button view and button references, and ensure the button is present in the
Childrencollection:This ensures that:
Testing
Added a unit test to verify that the OK button remains stable after various property changes and multiple dialog interactions.
The fix is minimal, surgical, and addresses the core issue without introducing side effects or breaking changes.
Fixes #238.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.