fix: make SfPicker respect HorizontalOptions and VerticalOptions for adjustable layout #196
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adjustable layout
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the internal PickerStackLayout honors the control’s HorizontalOptions and VerticalOptions, improving its sizing and alignment behavior.
- Applies
HorizontalOptionsandVerticalOptionsto the internal layout. - Fixes layout responsiveness without introducing breaking changes.
Comments suppressed due to low confidence (1)
maui/src/Picker/PickerBase.cs:242
- There are no tests verifying that the picker respects HorizontalOptions and VerticalOptions. Consider adding a UI or layout unit test to confirm these properties are applied correctly in various scenarios.
_pickerStackLayout = new PickerStackLayout(this);
| @@ -240,6 +240,8 @@ void UpdateFormatBasedOnCulture() | |||
| void AddChildren() | |||
| { | |||
| _pickerStackLayout = new PickerStackLayout(this); | |||
| _pickerStackLayout.HorizontalOptions = this.HorizontalOptions; | |||
There was a problem hiding this comment.
HorizontalOptions and VerticalOptions are only set once during AddChildren. If these properties change at runtime, the layout won’t update. Consider overriding OnPropertyChanged for HorizontalOptions and VerticalOptions to reapply them on the internal layout.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the internal PickerStackLayout in SfPicker to respect the HorizontalOptions and VerticalOptions properties set on the picker control. This allows the picker to be sized and aligned according to these layout options, fixing the issue where the picker did not adjust its size or alignment as expected.