Skip to content
This repository was archived by the owner on Nov 14, 2019. It is now read-only.

Extracted the code related to Composer into a new ComposerManager class #279

Closed
wants to merge 4 commits into from

Conversation

javiereguiluz
Copy link
Member

  • This is just a code refactor, no new features were introduced.
  • This is the first step into improving the code quality and making it easier to test.

I have a question: I don't know which is the best way to uncomment these lines. Should we pass the output object to the Composer manager? Thanks.

// ));
// }

return $this;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

returning itself looks wrong to me.

And the fact that this is extracted into a dedicated private method does not stop the process anymore when the path is not writable (well, it will likely stop it due to the broken return value)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the return $this; was a leftover of the previous code.

In any case, we can remove the old warning message because returning an empty array when the Composer config is not readable will make the application work as expected.

@javiereguiluz
Copy link
Member Author

Closing in favor of #282 because there are some errors that I can't fix. @stof I did the changes that you asked. Thanks.

javiereguiluz added a commit that referenced this pull request Oct 12, 2016
…ds (javiereguiluz)

This PR was squashed before being merged into the 1.0-dev branch (closes #282).

Discussion
----------

Introduce a ComposerManager class to simplify the commands

This replaces #279.

Commits
-------

28dafd2 Introduce a ComposerManager class to simplify the commands
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants