This repository was archived by the owner on Nov 14, 2019. It is now read-only.
Fix lowercase issues with unicode characters #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would also remove any char not allowed in a composer package name (see the composer source code for their regex) |
stof
reviewed
Sep 30, 2016
| ['çįßłŵž', 'cislwz'], | ||
| ]; | ||
| } | ||
| } |
|
👍 for this 😄 Just need to make sure the box build works for php 5.4, or remove the travis build for this case |
javiereguiluz
added a commit
that referenced
this pull request
Oct 5, 2016
…viereguiluz) This PR was merged into the 1.0-dev branch. Discussion ---------- Fix lowercase issues with unicode characters @Pierstoval I tried your proposal in #197 but it didn't work for me. This new PR proposes to fix most of the errors for European languages. Sadly it won't work for Japanese, Chinese, Arabic, Hebrew, etc. Commits ------- 19b6799 Missing EOL 74d991b Clean the package names using the same regexp as Composer 4773869 Finished this feature e1de703 Try to fix #190 by fixing lowercase package name
javiereguiluz
added a commit
to symfony/demo
that referenced
this pull request
Oct 14, 2016
This PR was squashed before being merged into the master branch (closes #389). Discussion ---------- Made the slugger compatible with every language In the Symfony Installer we recently made a change to forbid any non-Latin character in the project names ([see details](symfony/symfony-installer#278)). This is needed because Composer itself requires that for package names. In the Symfony Demo app we had a similar problem with the slugs of the blog posts. We removed any non-Latin character ... but that caused bugs like #136. I propose to change the slugger completely and accept any character. For example, you can now create this blog post:  And the blog listing no longer displays an error:  And the URL is perfectly fine although it contains non-Latin chars:  Commits ------- 161b508 Made the slugger compatible with every language
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Pierstoval I tried your proposal in #197 but it didn't work for me. This new PR proposes to fix most of the errors for European languages. Sadly it won't work for Japanese, Chinese, Arabic, Hebrew, etc.