This repository was archived by the owner on Nov 14, 2019. It is now read-only.
Using Guzzle instead of file_get_contents to fetch .gitignore file #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please revert the permission change. This file has no reason to be executable. If you are using Windows, see http://stackoverflow.com/questions/1580596/how-do-i-make-git-ignore-file-mode-chmod-changes for the way to tell git to ignore them (as Windows does not support Unix permissions). I think GitBash configures this by default, but maybe not other installers. |
|
Done. Windows always gets me! |
|
👍 |
|
@mariuspuiu thanks for this. It's useful and makes the code more consistent. |
javiereguiluz
added a commit
that referenced
this pull request
Apr 1, 2016
…gnore file (marius.puiu, mariuspuiu) This PR was merged into the 1.0-dev branch. Discussion ---------- Using Guzzle instead of file_get_contents to fetch .gitignore file Fixing issue #242 Replaced `file_get_contents` to get `.gitignore` file with `Guzzle` (to bypass proxy issues). Commits ------- ca2db3a Reverted DownloadCommand.php permissions 352f4d9 Using Guzzle instead of file_get_contents to fetch .gitignore file (issue #242)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #242
Replaced
file_get_contentsto get.gitignorefile withGuzzle(to bypass proxy issues).